Fix incorrect shadow color deserialization/serialization

Previously, packetevents expected shadow color to be serialized as a hex string Vanilla serializes shadow colors as a single integer instead
retrooper · Jan 18, 2025 · e1df407 · e1df407
1 parent 6507a73
commit e1df407
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/...rc/main/java/com/github/retrooper/packetevents/util/adventure/AdventureNBTSerializer.java b/...rc/main/java/com/github/retrooper/packetevents/util/adventure/AdventureNBTSerializer.java
@@ -331,10 +331,8 @@ public AdventureNBTSerializer(boolean downsampleColor) {
             if (color != null) style.color(color);
         });
         if (BackwardCompatUtil.IS_4_18_0_OR_NEWER) {
-            reader.useUTF("shadow_color", value -> {
-                ShadowColor color = ShadowColor.fromHexString(value);
-                if (color != null) style.shadowColor(color);
-            });
+            reader.useNumber("shadow_color", num ->
+                    style.shadowColor(ShadowColor.shadowColor(num.intValue())));
         }
 
         for (String decorationKey : TextDecoration.NAMES.keys()) {
@@ -413,7 +411,7 @@ public AdventureNBTSerializer(boolean downsampleColor) {
 
         if (BackwardCompatUtil.IS_4_18_0_OR_NEWER) {
             ShadowColor shadowColor = style.shadowColor();
-            if (shadowColor != null) writer.writeUTF("shadow_color", shadowColor.asHexString());
+            if (shadowColor != null) writer.writeInt("shadow_color", shadowColor.value());
         }
 
         for (TextDecoration decoration : TextDecoration.NAMES.values()) {