Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NAMED_SOUND_EFFECT to CUSTOM_SOUND_EFFECT as SOUND_EFFECT is doing the work of NAMED_SOUND_EFFECT #914

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ public enum Server implements PacketTypeCommon, ClientBoundPacket {
SCULK_VIBRATION_SIGNAL,
ACKNOWLEDGE_PLAYER_DIGGING,
CHAT_PREVIEW_PACKET,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
PLAYER_CHAT_HEADER,
PLAYER_INFO,
DISPLAY_CHAT_PREVIEW,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public enum ClientboundPacketType_1_12 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public enum ClientboundPacketType_1_12_1 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public enum ClientboundPacketType_1_13 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public enum ClientboundPacketType_1_14 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public enum ClientboundPacketType_1_14_4 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public enum ClientboundPacketType_1_15 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public enum ClientboundPacketType_1_15_2 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public enum ClientboundPacketType_1_16 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public enum ClientboundPacketType_1_16_2 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public enum ClientboundPacketType_1_17 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public enum ClientboundPacketType_1_18 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public enum ClientboundPacketType_1_19 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public enum ClientboundPacketType_1_19_1 {
CUSTOM_CHAT_COMPLETIONS,

PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,

//Added in 1.19.1
DELETE_CHAT,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public enum ClientboundPacketType_1_19_3 {
PLUGIN_MESSAGE,

//Removed in 1.19.3
//NAMED_SOUND_EFFECT,
//CUSTOM_SOUND_EFFECT,

//Added in 1.19.1
DELETE_CHAT,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public enum ClientboundPacketType_1_9 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public enum ClientboundPacketType_1_9_3 {
SET_SLOT,
SET_COOLDOWN,
PLUGIN_MESSAGE,
NAMED_SOUND_EFFECT,
CUSTOM_SOUND_EFFECT,
DISCONNECT,
ENTITY_STATUS,
EXPLOSION,
Expand Down