fix: Return event details upon creation (#512)

revertinc · Mar 11, 2024 · 002f116 · 002f116
1 parent 3c637e4
commit 002f116
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 15 deletions.
diff --git a/packages/backend/services/crm/contact.ts b/packages/backend/services/crm/contact.ts
@@ -832,19 +832,26 @@ const contactService = new ContactService(
                                 authorization: `Zoho-oauthtoken ${thirdPartyToken}`,
                             },
                         });
-                        contacts = contacts.data.data;
-                        contacts = await Promise.all(
-                            contacts?.map(
-                                async (l: any) =>
-                                    await unifyObject<any, UnifiedContact>({
-                                        obj: l,
-                                        tpId: thirdPartyId,
-                                        objType,
-                                        tenantSchemaMappingId: connection.schema_mapping_id,
-                                        accountFieldMappingConfig: account.accountFieldMappingConfig,
-                                    })
-                            )
-                        );
+                        const isValidContactData =
+                            contacts.data && contacts.data.data !== undefined && Array.isArray(contacts.data.data);
+                        if (isValidContactData) {
+                            contacts = contacts?.data?.data;
+
+                            contacts = await Promise.all(
+                                contacts?.map(
+                                    async (l: any) =>
+                                        await unifyObject<any, UnifiedContact>({
+                                            obj: l,
+                                            tpId: thirdPartyId,
+                                            objType,
+                                            tenantSchemaMappingId: connection.schema_mapping_id,
+                                            accountFieldMappingConfig: account.accountFieldMappingConfig,
+                                        })
+                                )
+                            );
+                        } else {
+                            contacts = [];
+                        }
                         res.send({ status: 'ok', results: contacts });
                         break;
                     }

diff --git a/packages/backend/services/crm/event.ts b/packages/backend/services/crm/event.ts
@@ -469,15 +469,19 @@ const eventService = new EventService(
                         break;
                     }
                     case TP_ID.zohocrm: {
-                        await axios({
+                        const eventCreated: any = await axios({
                             method: 'post',
                             url: `https://www.zohoapis.com/crm/v3/Events`,
                             headers: {
                                 authorization: `Zoho-oauthtoken ${thirdPartyToken}`,
                             },
                             data: JSON.stringify(event),
                         });
-                        res.send({ status: 'ok', message: 'Zoho event created', result: event });
+                        res.send({
+                            status: 'ok',
+                            message: 'Zoho event created',
+                            result: { ...event, details: eventCreated.data.data[0].details },
+                        });
                         break;
                     }
                     case TP_ID.sfdc: {