Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharedContext argument to glfwCreateWindow #82

Merged
merged 10 commits into from
Jan 22, 2019

Conversation

lpalmes
Copy link
Member

@lpalmes lpalmes commented Jan 21, 2019

The glfwCreateWindow will have a new optional labeled argument to share context between windows (textures, etc):

glfwCreateWindow: (int, int, ~sharedContext: Window.t=?, string) => Window.t;

This will allow revery-ui/revery#224 to work.

@bryphe
Copy link
Member

bryphe commented Jan 21, 2019

Thanks for figuring this out, @lpalmes! 💯

Change looks good to me. Since we're adding a lock folder - we'll need to upgrade esy to 0.4.9 in the .travis.yml file, though - travis right now is using [email protected] which doesn't recognize that lock directory format.

@bryphe bryphe merged commit 000c393 into revery-ui:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants