Scroll for smaller amounts #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
approved these changes
Feb 5, 2019
|
Thanks @jchavarri , nice catch! Looks like CI is failing due to formatting - might want to try |
|
Thanks @bryphe ! I ran refmt and now CI is happy. One small thing I realized is that to make sure Merging then! |
akinsho
pushed a commit
to akinsho/revery
that referenced
this pull request
Feb 18, 2019
* Scroll for smaller amounts * refmt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No companion issue. Found while investigating #288.
When the wheel event would return
0.xwe wouldn't move the scroll position. This PR changes the calculation order so that we multiple first by 25 and then round, so every event causes some effect, even if small.