Calculate additional bounties #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cajubelt
reviewed
Feb 13, 2022
| @@ -13,6 +13,11 @@ interface IRevoBounty { | |||
| view | |||
| returns (TokenAmount[] memory); | |||
|
|
|||
| function calculateAdditionalBountyFee(TokenAmount[] calldata interestAccrued) | |||
There was a problem hiding this comment.
In my mind, a "bounty fee" is a fee the user pays that turns into a bounty for the person who calls claimRewards to collect. By that logic though, "additional bounty fee" doesn't make sense. The "additional bounty" is not funded by fees. It's a bounty that Revo pays for, presumably out of the community fund (which will have governance tokens, withdrawal fees, etc)
There was a problem hiding this comment.
I think calculateAdditionalBounty would be easier to understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12