feat: allow setting Redis connection options #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redis.from_url
may accept connection options specified as kwargs. They're not particularly documented, but a list may be found in the source code:I think most people don't need them and
django-health-check
works fine with the defaults.That said, there is one particular case which I think
django-health-check
needs to deal with which is e.g. Heroku uses self signed certificates which causes the connection to fail (raising aConnectionError
) which in turn makes the Redis health check to report the service as unavailable. The issue can be worked around by disabling SSL verification. In order to do that, one needs to passssl_cert_reqs=None
to the connection object.This PR introduces a new variable
HEALTHCHECK_REDIS_URL_OPTIONS
which allows one to customise the connection if they need to.