Add Support For New Trimmer UI #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
13
to
17
| var durationText:String { | ||
| let totalSeconds = Int(CMTimeGetSeconds(self)) | ||
| let hours:Int = Int(totalSeconds / 3600) | ||
| let minutes:Int = Int(totalSeconds % 3600 / 60) | ||
| let seconds:Int = Int((totalSeconds % 3600) % 60) |
There was a problem hiding this comment.
Suggested change
| var durationText:String { | |
| let totalSeconds = Int(CMTimeGetSeconds(self)) | |
| let hours:Int = Int(totalSeconds / 3600) | |
| let minutes:Int = Int(totalSeconds % 3600 / 60) | |
| let seconds:Int = Int((totalSeconds % 3600) % 60) | |
| var durationText: String { | |
| let totalSeconds = Int(CMTimeGetSeconds(self)) | |
| let hours: Int = Int(totalSeconds / 3600) | |
| let minutes: Int = Int(totalSeconds % 3600 / 60) | |
| let seconds: Int = Int(totalSeconds % 3600 % 60) |
There was a problem hiding this comment.
@MikkoKuivanenRS Updated as well.
Base automatically changed from
CC-505-creators-can-view-video-lengths-when-editing-in-storytelling-posts
to
master
January 25, 2024 14:35
…n-editing-in-storytelling-posts-trimmer-view # Conflicts: # Source/Filters/Video/YPVideoFiltersVC.swift # YPImagePicker.xcodeproj/project.pbxproj
…storytelling-posts-trimmer-view' into CC-505-creators-can-view-video-lengths-when-editing-in-storytelling-posts-trimmer-view-time-stamp-rules
…storytelling-posts-trimmer-view' into CC-505-creators-can-view-video-lengths-when-editing-in-storytelling-posts-trimmer-view-time-stamp-rules
…o-lengths-when-editing-in-storytelling-posts-trimmer-view-time-stamp-rules Adds TimeStamp UI Rule Updates
iirovi-rs
reviewed
Jan 30, 2024
| @@ -18,7 +18,7 @@ let package = Package( | |||
| ), | |||
| .package( | |||
| url: "https://github.com/rewardStyle/PryntTrimmerView", | |||
| .exact("4.0.2") | |||
| .branch("CC-505-creators-can-view-video-lengths-when-editing-in-storytelling-posts") | |||
There was a problem hiding this comment.
Just putting a note here so that we'll remember to switch this back once we release the new version of PryntTrimmerView. That PR approved so we could probably release it already?
There was a problem hiding this comment.
@iirovi-rs Updated here: cb6feb2
| // MARK: - Init | ||
|
|
||
| public override func layoutSubviews() { | ||
| if !isLaidOut { |
There was a problem hiding this comment.
do we need to call super.layoutSubviews() here
There was a problem hiding this comment.
@MikkoKuivanenRS Updated here: 9caf060
MikkoKuivanenRS
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new view
YPTimeStampTrimmerViewwith support for showing the trimmer with bottom timestamps as well as timestamps when dragging the left and right handles. This PR also adds some newYPConfigoptions that the client can set for customization.