Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak with updateViewFrameAction #38

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

MikkoKuivanenRS
Copy link

No description provided.

Copy link

@zeph-cohen10 zeph-cohen10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikkoKuivanenRS Where was this leaking, just in general cover image selection?

@MikkoKuivanenRS
Copy link
Author

MikkoKuivanenRS commented Feb 22, 2024

Just opening the image picker for example would cause it, but pretty much anything that had YPAdjustableView and used updateViewFrameAction "the wrong way".
In this case YPVideoView was retained.
Easy to check by going to create post opening add media and cancelling everything back to home screen and checking memory graph.

@zeph-cohen10
Copy link

Just opening the image picker for example would cause it, but pretty much anything that had YPAdjustableView and used updateViewFrameAction "the wrong way". In this case YPVideoView was retained. Easy to check by going to create post opening add media and cancelling everything back to home screen and checking memory graph.

Good find 👍

@MikkoKuivanenRS MikkoKuivanenRS merged commit 215a939 into master Feb 28, 2024
2 of 3 checks passed
@MikkoKuivanenRS MikkoKuivanenRS deleted the memoryleak branch February 28, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants