Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Cover Photo UAT Low Priority Issue Fixes #58

Merged
merged 12 commits into from
Dec 20, 2024
Merged

Custom Cover Photo UAT Low Priority Issue Fixes #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2e3e7b5
fix: update prynttrimmerview version
zeph-cohen10 Dec 13, 2024
7b97812
update prynttrimmerview in package.swift
zeph-cohen10 Dec 13, 2024
599ba39
chore: update prynttrimmerview
zeph-cohen10 Dec 13, 2024
68ca10d
fix: reset thumb selector border color + update printtrymmerview
zeph-cohen10 Dec 13, 2024
9e63694
fix: provide mechanism to communicate custom cover photo replacement
zeph-cohen10 Dec 17, 2024
badabf9
update prynttrimmerview
zeph-cohen10 Dec 18, 2024
2cc6fd7
update prynttrimmerview
zeph-cohen10 Dec 18, 2024
746eed6
update image picker
zeph-cohen10 Dec 18, 2024
37ba491
update prynttrimmerview
zeph-cohen10 Dec 20, 2024
3743228
fix: update prynttrimmerview reference
zeph-cohen10 Dec 20, 2024
08cf913
update trimmer
zeph-cohen10 Dec 20, 2024
deda417
update to final prynttrimmerview reference
zeph-cohen10 Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ let package = Package(
),
.package(
url: "https://github.com/rewardStyle/PryntTrimmerView",
.exact("4.0.3")
.exact("4.0.4")
)

],
Expand Down
4 changes: 4 additions & 0 deletions Source/Filters/Video/YPVideoFiltersVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ open class YPVideoFiltersVC: UIViewController, IsMediaFilterVC {
public var shouldShowDone = false
public weak var videoProcessingDelegate: YPVideoProcessingDelegate?
public var isUsingCustomCoverImage = false
public var customCoverImageReplacedHandler: (() -> Void)?

var coverImageTime: CMTime?
var coverTrimTimes: (startTime: CMTime, endTime: CMTime)?
Expand Down Expand Up @@ -551,6 +552,8 @@ open class YPVideoFiltersVC: UIViewController, IsMediaFilterVC {
self?.imageGenerator?.cancelAllCGImageGeneration()
self?.coverImageView.image = UIImage(cgImage: image)
self?.coverImageTime = time
self?.isUsingCustomCoverImage = false
self?.customCoverImageReplacedHandler?()
}
})
}
Expand Down Expand Up @@ -627,6 +630,7 @@ extension YPVideoFiltersVC: YPTimeStampTrimmerViewDelegate {
// MARK: - ThumbSelectorViewDelegate
extension YPVideoFiltersVC: ThumbSelectorViewDelegate {
public func didChangeThumbPosition(_ imageTime: CMTime) {
coverThumbSelectorView.resetThumbViewBorderColor()
// fetch new image
if !isUsingCustomCoverImage || vcType == .Cover {
generateCoverImageAtTime(imageTime)
Expand Down
2 changes: 1 addition & 1 deletion YPImagePicker.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,7 +1373,7 @@
repositoryURL = "https://github.com/rewardstyle/prynttrimmerview";
requirement = {
kind = exactVersion;
version = 4.0.3;
version = 4.0.4;
};
};
EBA37BCB26F75BCC005DAAD4 /* XCRemoteSwiftPackageReference "Stevia" */ = {
Expand Down
4 changes: 2 additions & 2 deletions YPImagePicker.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/rewardstyle/prynttrimmerview",
"state" : {
"revision" : "267a4b08213af5d8803e849c6ba7399928628752",
"version" : "4.0.3"
"revision" : "59379933130df86e35b6f6a60aefa7262368854a",
"version" : "4.0.4"
}
},
{
Expand Down