First cut at RI state calculator #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hold the reviews; I'm just going to keep going on the latest design rev. No point reviewing an implementation that's going to be mostly replaced very soon. |
This is still missing the icon tabs, which means it's also missing the selector UI for the "other" incentives.
For the frontend's project selector, we want to combine several of the API's item types (e.g. `new_electric_vehicle` and `used_electric_vehicle`) into a single project. This introduces the abstraction layer to allow that.
This makes an effort to make it read nicely. It's not localizable, but that's OK for now; RI does not seem to care about having the calculator available in other languages.
It switches to a dropdown on small layout, but it's just a plain dropdown; doesn't have the little icons.
|
Ditching this in favor of #20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New .html page for the RI calculator
Card-based presentation of incentives, rather than the table like in
the IRA calculator. This follows the initial designs.
No utility incentives yet, only state + federal. Utility selection
will come in a followup.
If you enter a non-RI zip code, the API gives the error "we don't yet
have state-level coverage in ". This isn't exactly what we want
-- it should say "that zip/address is not in Rhode Island". This will
require an API change to add a "state" parameter.
Test Plan
Enter a RI zip code and make sure that RI incentives come up.
Note this new page will not be available in the Vercel preview. I
haven't configured the Parcel build to include
rhode-island.htmlyet, because I don't want the page to be publicly available when this
lands.
Next Steps
Follow-up PRs that add the utility and project fields.