Small refactoring + error reporting #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,24 +1,20 @@ | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
let's just remove this comment, doesn't belong in the source code
|
@necolas, thanks for the review, I'll check rework-vars updates & handle your comments tomorrow morning + release 0.3.0 |
Just a PR following my stupid #3 I’ve refactored the code a little bit (& also use rework-visit which is more bullet proof) like rework-vars. I quickly refactor tests to make it more understandable. I add some error reporting like we have in rework-vars. Btw, maybe we can expand the use of balanced-match to rewrite other parts of the plugin.
MoOx
added a commit
that referenced
this pull request
Jun 21, 2014
Small refactoring + error reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a PR following my stupid
#3
I’ve refactored the code a little bit (& also use rework-visit which is
more bullet proof) like rework-vars.
I quickly refactor tests to make it more understandable.
I add some error reporting like we have in rework-vars.
Btw, maybe we can expand the use of balanced-match to rewrite other
parts of the plugin.
poke @necolas