Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validation #21

Merged
merged 3 commits into from
May 22, 2024
Merged

Schema validation #21

merged 3 commits into from
May 22, 2024

Conversation

snshn
Copy link
Contributor

@snshn snshn commented May 22, 2024

No description provided.

harambe/core.py Outdated Show resolved Hide resolved
harambe/core.py Outdated Show resolved Hide resolved
tests/test_sdk.py Outdated Show resolved Hide resolved
class SchemaValidationError(Exception):
def __init__(self, schema, data):
super().__init__(
"Data {data} does not match schema {schema}".format(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be nice to know which field specifically is erroring

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exception is fed into our model so the more context the better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done in #22

@asim-shrestha asim-shrestha merged commit 0cd1c6d into main May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants