Add support for readable event #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you upgraded serial port, are api compatible? |
|
Hi Rocco,
I’m not sure I understand your question. I added support for the “readable” event, which is part of the node-serialport API.
Please let me know if you need more information.
Thanks,
Mike
From: Rocco Musolino <[email protected]>
Sent: Thursday, March 7, 2019 12:34 PM
To: reyiyo/virtual-serialport <[email protected]>
Cc: Strong, Michael D <[email protected]>; Author <[email protected]>
Subject: Re: [reyiyo/virtual-serialport] Add support for readable event (#22)
The following message was sent from an external e-mail address. Be cautious when clicking on links, opening attachments or providing sensitive information.
…________________________________
you upgraded serial port, are api compatible?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#22 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AP5VQZC-OhOJOzKvGWNyTO0U8vVQk20Fks5vUU1ugaJpZM4bjmX->.
|
|
You upgraded |
|
Not that I am aware of.
From: Rocco Musolino <[email protected]>
Sent: Tuesday, April 16, 2019 9:15 PM
To: reyiyo/virtual-serialport <[email protected]>
Cc: Strong, Michael D <[email protected]>; Author <[email protected]>
Subject: Re: [reyiyo/virtual-serialport] Add support for readable event (#22)
The following message was sent from an external e-mail address. Be cautious when clicking on links, opening attachments or providing sensitive information.
…________________________________
You upgraded serialport version to 6.2.1 in optionalDependencies.
Are there any breaking change?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#22 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AP5VQd0IWOkpPjJCJN2Ug4B6z9PcT65Cks5vhnWdgaJpZM4bjmX->.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for the "readable" event and bumped the versions of the the dependencies in the package file. I required the readable event for a test harness I'm working on. Thanks.