dnsdist: Fix a few warnings from Coverity

rgacogne · Sep 13, 2024 · 1341a0a · 1341a0a
1 parent 6913cd5
commit 1341a0a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/pdns/dnsdistdist/bpf-filter.cc b/pdns/dnsdistdist/bpf-filter.cc
@@ -392,7 +392,7 @@ BPFFilter::BPFFilter(std::unordered_map<std::string, MapConfiguration>& configs,
     BPFFilter::MapConfiguration filters;
     filters.d_maxItems = 1;
     filters.d_type = BPFFilter::MapType::Filters;
-    maps->d_filters = BPFFilter::Map(filters, d_mapFormat);
+    maps->d_filters = BPFFilter::Map(std::move(filters), d_mapFormat);
 
     const struct bpf_insn main_filter[] = {
 #include "bpf-filter.main.ebpf"

diff --git a/pdns/dnsdistdist/dnsdist-web.cc b/pdns/dnsdistdist/dnsdist-web.cc
@@ -1908,6 +1908,7 @@ void setMaxConcurrentConnections(size_t max)
 void WebserverThread(Socket sock)
 {
   setThreadName("dnsdist/webserv");
+  //coverity[auto_causes_copy]
   const auto local = *dnsdist::configuration::getCurrentRuntimeConfiguration().d_webServerAddress;
   infolog("Webserver launched on %s", local.toStringWithPort());
 

diff --git a/pdns/dnsdistdist/dnsdist.cc b/pdns/dnsdistdist/dnsdist.cc
@@ -2340,6 +2340,7 @@ static void healthChecksThread()
 
     std::unique_ptr<FDMultiplexer> mplexer{nullptr};
     // this points to the actual shared_ptrs!
+    //coverity[auto_causes_copy]
     const auto servers = dnsdist::configuration::getCurrentRuntimeConfiguration().d_backends;
     for (const auto& dss : servers) {
       dss->updateStatisticsInfo();