dnsdist: Fix a clang-tidy warning in bpf-filter.cc

rgacogne · Sep 12, 2024 · bf68249 · bf68249
1 parent 8524623
commit bf68249
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pdns/dnsdistdist/bpf-filter.cc b/pdns/dnsdistdist/bpf-filter.cc
@@ -35,6 +35,7 @@
 
 static __u64 ptr_to_u64(const void* ptr)
 {
+  // NOLINTNEXTLINE(cppcoreguidelines-pro-type-cstyle-cast)
   return (__u64)(unsigned long)ptr;
 }
 
@@ -195,8 +196,8 @@ struct QNameValue
   uint16_t qtype{0};
 };
 
-BPFFilter::Map::Map(const BPFFilter::MapConfiguration& config, BPFFilter::MapFormat format) :
-  d_config(config)
+BPFFilter::Map::Map(BPFFilter::MapConfiguration config, BPFFilter::MapFormat format) :
+  d_config(std::move(config))
 {
   if (d_config.d_type == BPFFilter::MapType::Filters) {
     /* special case, this is a map of eBPF programs */

diff --git a/pdns/dnsdistdist/bpf-filter.hh b/pdns/dnsdistdist/bpf-filter.hh
@@ -111,7 +111,7 @@ private:
     Map()
     {
     }
-    Map(const MapConfiguration&, MapFormat);
+    Map(MapConfiguration, MapFormat);
     MapConfiguration d_config;
     uint32_t d_count{0};
     FDWrapper d_fd;