forked from PowerDNS/pdns
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dns.cc: use pdns::views::UnsignedCharView
Includes minor cleanup and additions to make UnsignedCharView usable for this use case. Supersedes PowerDNS#14356 Fixes /usr/include/c++/v1/__fwd/string_view.h:22:41: warning: 'char_traits<unsigned char>' is deprecated: char_traits<T> for T not equal to char, wchar_t, char8_t, char16_t or char32_t is non-standard and is provided for a temporary period. It will be removed in LLVM 19, so please migrate off of it. [-Wdeprecated-declarations]
- Loading branch information
Showing
4 changed files
with
84 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../views.hh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
/* | ||
* This file is part of PowerDNS or dnsdist. | ||
* Copyright -- PowerDNS.COM B.V. and its contributors | ||
* | ||
* This program is free software; you can redistribute it and/or modify | ||
* it under the terms of version 2 of the GNU General Public License as | ||
* published by the Free Software Foundation. | ||
* | ||
* In addition, for the avoidance of any doubt, permission is granted to | ||
* link this program with OpenSSL and to (re)distribute the binaries | ||
* produced as the result of such linking. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program; if not, write to the Free Software | ||
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | ||
*/ | ||
#pragma once | ||
|
||
#include <string_view> | ||
|
||
namespace pdns::views | ||
{ | ||
|
||
class UnsignedCharView | ||
{ | ||
public: | ||
UnsignedCharView(const char* data_, size_t size_) : | ||
view(data_, size_) | ||
{ | ||
} | ||
// NOLINTBEGIN(cppcoreguidelines-pro-type-reinterpret-cast): No unsigned char view in C++17 | ||
UnsignedCharView(const unsigned char* data_, size_t size_) : | ||
view(reinterpret_cast<const char*>(data_), size_) | ||
{ | ||
} | ||
using size_type = std::string_view::size_type; | ||
|
||
[[nodiscard]] const unsigned char& at(size_type pos) const | ||
{ | ||
return reinterpret_cast<const unsigned char&>(view.at(pos)); | ||
} | ||
|
||
[[nodiscard]] const unsigned char& operator[](size_type pos) const | ||
{ | ||
return reinterpret_cast<const unsigned char&>(view[pos]); | ||
} | ||
|
||
[[nodiscard]] const unsigned char* data() const | ||
{ | ||
return reinterpret_cast<const unsigned char*>(view.data()); | ||
} | ||
// NOLINTEND(cppcoreguidelines-pro-type-reinterpret-cast): No unsigned char view in C++17 | ||
|
||
[[nodiscard]] size_t size() const | ||
{ | ||
return view.size(); | ||
} | ||
|
||
[[nodiscard]] size_t length() const | ||
{ | ||
return view.length(); | ||
} | ||
|
||
private: | ||
std::string_view view; | ||
}; | ||
|
||
} |