Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xsk debug qname optim #13

Closed
wants to merge 59 commits into from
Closed

Xsk debug qname optim #13

wants to merge 59 commits into from

Commits on Jan 9, 2024

  1. Refactor RPZ download thread code

    @omoerbeek
    omoerbeek committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    4fc57a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. RPZ notify

    @omoerbeek
    omoerbeek committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b59c7fc View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Tidy

    @omoerbeek
    omoerbeek committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    29691be View commit details
    Browse the repository at this point in the history

  2. Add test, only clear cache if the notify wasn't for an RPZ

    @omoerbeek
    omoerbeek committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    046b69a View commit details
    Browse the repository at this point in the history

  3. Docs

    @omoerbeek
    omoerbeek committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    7e9fbf9 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. dnsname: move len and offset from int to size_t

    @chbruyand
    chbruyand committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    cce0983 View commit details
    Browse the repository at this point in the history

  2. dnsname: clang-tidy fix a few missing braces

    @chbruyand
    chbruyand committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    05fe745 View commit details
    Browse the repository at this point in the history

  3. dnsname: tidy some implicit conversion

    @chbruyand
    chbruyand committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    7cd99b0 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Process comments from review by @rgacogne, thanks!

    @omoerbeek
    omoerbeek committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1440623 View commit details
    Browse the repository at this point in the history

  2. Rate limit the notifies per zone to max 1 per 5 sec (less if refresh … 

    …is lower)
    @omoerbeek
    omoerbeek committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c33b024 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. dnsname: remove unnecessary cast as suggested by Otto

    @chbruyand
    chbruyand committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8e9a138 View commit details
    Browse the repository at this point in the history

  2. Make the refresh 1 again, to work around the new rate limiting

    @omoerbeek
    omoerbeek committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    71ada8e View commit details
    Browse the repository at this point in the history

  3. Merge pull request PowerDNS#13701 from omoerbeek/rec-rpz-refactor 

    rec: RPZ from primary refactor and allow notifies for RPZs
    @omoerbeek
    omoerbeek authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f3f8d99 View commit details
    Browse the repository at this point in the history

  4. Merge pull request PowerDNS#13723 from chbruyand/dnsname-position-types 

    DNSName: correct len and offset types
    @rgacogne
    rgacogne authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    9b4a83a View commit details
    Browse the repository at this point in the history

  5. dnsdist: add AF_XDP support for udp 

    Signed-off-by: Y7n05h <[email protected]>
    @Y7n05h @rgacogne
    Y7n05h authored and rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    a61dd3f View commit details
    Browse the repository at this point in the history

  6. dnsdist: Better error messages when failing to load the XDP map

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    bbb193a View commit details
    Browse the repository at this point in the history

  7. dnsdist: Prevent a false-positive warning from the compiler 

    ```
In file included from xsk.hh:50,
                 from xsk.cc:23:
In function ‘xdp_desc* xsk_ring_prod__tx_desc(xsk_ring_prod*, __u32)’,
    inlined from ‘void XskSocket::send(std::vector<std::unique_ptr<XskPacket>, std::allocator<std::unique_ptr<XskPacket> > >&)’ at xsk.cc:176:28:
/usr/include/xdp/xsk.h:76:27: warning: ‘idx’ may be used uninitialized [-Wmaybe-uninitialized]
   76 |         return &descs[idx & tx->mask];
      |                       ~~~~^~~~~~~~~~
```
    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d7a4f1f View commit details
    Browse the repository at this point in the history

  8. dnsdist: Add an option to easily disable XDP logging (default)

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f3eb524 View commit details
    Browse the repository at this point in the history

  9. dnsdist: Pass-through TCP packets from XDP

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c3cad01 View commit details
    Browse the repository at this point in the history

  10. dnsdist: Punt fragmented UDP dgrams to the kernel in xdp-filter

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7d0d8ed View commit details
    Browse the repository at this point in the history

  11. dnsdist: Fix parameter validation with XSK

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    bb8ab11 View commit details
    Browse the repository at this point in the history

  12. dnsdist: Add comments to the XSK code

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b1dd62e View commit details
    Browse the repository at this point in the history

  13. dnsdist: Add a XskSocket::getMetrics() binding

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    57131ee View commit details
    Browse the repository at this point in the history

  14. dnsdist: Fall-back to non-XSK for too large responses

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    953dc1e View commit details
    Browse the repository at this point in the history

  15. dnsdist: Small cleanup of the XSK code

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ce2e132 View commit details
    Browse the repository at this point in the history

  16. dnsdist: Better detection of libbpf and libxdp

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    961e2a7 View commit details
    Browse the repository at this point in the history

  17. dnsdist: Fix AF_XDP (XSK) detection

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cad1ba8 View commit details
    Browse the repository at this point in the history

  18. dnsdist: Minor clean ups in the XSK code

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4dd6b4b View commit details
    Browse the repository at this point in the history

  19. dnsdist: Fix a UMEM corruption in XSK 

    The second parameter to `xsk_ring_prod__submit` is the number of
processed items, not the final index.
    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    954a989 View commit details
    Browse the repository at this point in the history

  20. dnsdist: Cleanup of the XSK code, fixing alignment issues 

    Also add UMEM checks for debugging.
    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    677f9d2 View commit details
    Browse the repository at this point in the history

  21. dnsdist: Refactor the XSK code into a proper namespace

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ea24787 View commit details
    Browse the repository at this point in the history

  22. dnsdist: Get rid of memory allocations in the XSK hot path

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ae61f00 View commit details
    Browse the repository at this point in the history

  23. dnsdist: Fix XSK between dnsdist and its backends

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f140f2b View commit details
    Browse the repository at this point in the history

  24. dnsdist: Clean up and reorganize XSK code

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    2a5e976 View commit details
    Browse the repository at this point in the history

  25. dnsdist: Format and delint the XSK code

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cce416f View commit details
    Browse the repository at this point in the history

  26. dnsdist: Revert the now unneeded changes made to dnsdist-healthchecks

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    682b927 View commit details
    Browse the repository at this point in the history

  27. xdp.py: The ports set is now unused in XSK mode

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    39bbdd1 View commit details
    Browse the repository at this point in the history

  28. dnsdist: Report the AF_XDP feature

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    73a6da7 View commit details
    Browse the repository at this point in the history

  29. dnsdist: Document the XSK feature

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    366cc44 View commit details
    Browse the repository at this point in the history

  30. dnsdist: Add xsk, xskmap and umem to the spellchecker allow-list

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1b4bfa7 View commit details
    Browse the repository at this point in the history

  31. dnsdist: Fix XSK/AF_XDP detection

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    bd1e67a View commit details
    Browse the repository at this point in the history

  32. dnsdist: We need the regular, non-XSK threads as well!

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1c9b210 View commit details
    Browse the repository at this point in the history

  33. dnsdist: Fix a clang-tidy warning

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    38244a9 View commit details
    Browse the repository at this point in the history

  34. dnsdist: Add default values for the map and number of frames in newXsk

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    70b5d52 View commit details
    Browse the repository at this point in the history

  35. dnsdist: Install libbpf and libxdp in our CI image

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c184b26 View commit details
    Browse the repository at this point in the history

  36. dnsdist: Log whether UDP queries are forwarded via XSK

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    991210c View commit details
    Browse the repository at this point in the history

  37. dnsdist: Fix XSK over IPv6

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f928337 View commit details
    Browse the repository at this point in the history

  38. dnsdist: Log whether we are using XSK, and which mode (native or emul… 

    …ated)
    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    73dc64a View commit details
    Browse the repository at this point in the history

  39. dnsdist: Cosmetic fixes for XSK

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    40f605d View commit details
    Browse the repository at this point in the history

  40. dnsdist: Refactor XSK support between dnsdist and the backends

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    db96b41 View commit details
    Browse the repository at this point in the history

  41. dnsdist: Properly delay response packets in incoming-only XSK mode

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4b99619 View commit details
    Browse the repository at this point in the history

  42. dnsdist: Clear the XSK responder notification queue right away 

    Otherwise we might discard a valid notification between our last
look at the queue and the clearing.
    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    465bf9e View commit details
    Browse the repository at this point in the history

  43. dnsdist: Enable XSK (AF_XDP) on supported OSes

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    86b47ec View commit details
    Browse the repository at this point in the history

  44. dnsdist: Hopefully fix building with/without XDP in CI

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f941004 View commit details
    Browse the repository at this point in the history

  45. dnsdist: Switch to Debian 12 for our Docker image, enable XSK

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cf66dd2 View commit details
    Browse the repository at this point in the history

  46. dnsdist: Relax file descriptor check for XSK-enabled backends 

    We cannot guarantee that the response will be coming via XSK, so
we need to accept that a response that does not come from the
expected socket descriptor.
    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cd807ad View commit details
    Browse the repository at this point in the history

  47. dnsdist: Fix warnings from clang-tidy

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4a94ee5 View commit details
    Browse the repository at this point in the history

  48. dnsdist: Implement proper parameters handling in the XDP helper

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e053dc9 View commit details
    Browse the repository at this point in the history

  49. dnsdist: Fix more clang-tidy warnings

    @rgacogne
    rgacogne committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    94e3db7 View commit details
    Browse the repository at this point in the history