dnsdist: Move files (test) #14

rgacogne · 2024-01-29T15:48:34Z

Short description

Checklist

I have:

read the CONTRIBUTING.md document
compiled this code
tested this code
included documentation (including possible behaviour changes)
documented the code
added or modified regression test(s)
added or modified unit test(s)
checked that this code was merged to master

…is lower)

rec: RPZ from primary refactor and allow notifies for RPZs

DNSName: correct len and offset types

Signed-off-by: Y7n05h <[email protected]>

``` In file included from xsk.hh:50, from xsk.cc:23: In function ‘xdp_desc* xsk_ring_prod__tx_desc(xsk_ring_prod*, __u32)’, inlined from ‘void XskSocket::send(std::vector<std::unique_ptr<XskPacket>, std::allocator<std::unique_ptr<XskPacket> > >&)’ at xsk.cc:176:28: /usr/include/xdp/xsk.h:76:27: warning: ‘idx’ may be used uninitialized [-Wmaybe-uninitialized] 76 | return &descs[idx & tx->mask]; | ~~~~^~~~~~~~~~ ```

The second parameter to `xsk_ring_prod__submit` is the number of processed items, not the final index.

Also add UMEM checks for debugging.

…ated)

Otherwise we might discard a valid notification between our last look at the queue and the clearing.

We cannot guarantee that the response will be coming via XSK, so we need to accept that a response that does not come from the expected socket descriptor.

It was added in libbpf 0.7 and EL8 only has 0.5, sadly.

omoerbeek and others added 30 commits January 9, 2024 15:33

Refactor RPZ download thread code

4fc57a4

RPZ notify

b59c7fc

Tidy

29691be

Add test, only clear cache if the notify wasn't for an RPZ

046b69a

Docs

7e9fbf9

dnsname: move len and offset from int to size_t

cce0983

dnsname: clang-tidy fix a few missing braces

05fe745

dnsname: tidy some implicit conversion

7cd99b0

Process comments from review by @rgacogne, thanks!

1440623

Rate limit the notifies per zone to max 1 per 5 sec (less if refresh …

c33b024

…is lower)

dnsname: remove unnecessary cast as suggested by Otto

8e9a138

Make the refresh 1 again, to work around the new rate limiting

71ada8e

Merge pull request PowerDNS#13701 from omoerbeek/rec-rpz-refactor

f3f8d99

rec: RPZ from primary refactor and allow notifies for RPZs

Merge pull request PowerDNS#13723 from chbruyand/dnsname-position-types

9b4a83a

DNSName: correct len and offset types

dnsdist: add AF_XDP support for udp

a61dd3f

Signed-off-by: Y7n05h <[email protected]>

dnsdist: Better error messages when failing to load the XDP map

bbb193a

dnsdist: Add an option to easily disable XDP logging (default)

f3eb524

dnsdist: Pass-through TCP packets from XDP

c3cad01

dnsdist: Punt fragmented UDP dgrams to the kernel in xdp-filter

7d0d8ed

dnsdist: Fix parameter validation with XSK

bb8ab11

dnsdist: Add comments to the XSK code

b1dd62e

dnsdist: Add a XskSocket::getMetrics() binding

57131ee

dnsdist: Fall-back to non-XSK for too large responses

953dc1e

dnsdist: Small cleanup of the XSK code

ce2e132

dnsdist: Better detection of libbpf and libxdp

961e2a7

dnsdist: Fix AF_XDP (XSK) detection

cad1ba8

dnsdist: Minor clean ups in the XSK code

4dd6b4b

dnsdist: Fix a UMEM corruption in XSK

954a989

The second parameter to `xsk_ring_prod__submit` is the number of processed items, not the final index.

dnsdist: Cleanup of the XSK code, fixing alignment issues

677f9d2

Also add UMEM checks for debugging.

rgacogne added 28 commits January 23, 2024 12:54

dnsdist: Add xsk, xskmap and umem to the spellchecker allow-list

1b4bfa7

dnsdist: Fix XSK/AF_XDP detection

bd1e67a

dnsdist: We need the regular, non-XSK threads as well!

1c9b210

dnsdist: Fix a clang-tidy warning

38244a9

dnsdist: Add default values for the map and number of frames in newXsk

70b5d52

dnsdist: Install libbpf and libxdp in our CI image

c184b26

dnsdist: Log whether UDP queries are forwarded via XSK

991210c

dnsdist: Fix XSK over IPv6

f928337

dnsdist: Log whether we are using XSK, and which mode (native or emul…

73dc64a

…ated)

dnsdist: Cosmetic fixes for XSK

40f605d

dnsdist: Refactor XSK support between dnsdist and the backends

db96b41

dnsdist: Properly delay response packets in incoming-only XSK mode

4b99619

dnsdist: Clear the XSK responder notification queue right away

465bf9e

Otherwise we might discard a valid notification between our last look at the queue and the clearing.

dnsdist: Enable XSK (AF_XDP) on supported OSes

86b47ec

dnsdist: Hopefully fix building with/without XDP in CI

f941004

dnsdist: Switch to Debian 12 for our Docker image, enable XSK

cf66dd2

dnsdist: Relax file descriptor check for XSK-enabled backends

cd807ad

We cannot guarantee that the response will be coming via XSK, so we need to accept that a response that does not come from the expected socket descriptor.

dnsdist: Fix warnings from clang-tidy

4a94ee5

dnsdist: Implement proper parameters handling in the XDP helper

e053dc9

dnsdist: Fix more clang-tidy warnings

94e3db7

dnsdist: Update the XSK documentation for recent changes

ffbc306

spell-check: Allow libxdp

2a42c6c

dnsdist: Properly detect whether bpf_xdp_query is available

265ece9

It was added in libbpf 0.7 and EL8 only has 0.5, sadly.

dnsdist: Add a fuzzing target for the XSK code

a8c3569

dnsdist: Fix formatting of fuzz_xsk.cc

7478036

dnsdist: Remove symbolic links

dd69e52

dnsdist: Move dnsdist-only files from pdns/ to pdns/dnsdistdist

ac47e17

dnsdist: Format code

c40824f

rgacogne closed this Mar 21, 2024

rgacogne deleted the ddist-move-files-2 branch March 21, 2024 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dnsdist: Move files (test) #14

dnsdist: Move files (test) #14

rgacogne commented Jan 29, 2024

dnsdist: Move files (test) #14

dnsdist: Move files (test) #14

Conversation

rgacogne commented Jan 29, 2024

Short description

Checklist