Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noteable] merge update and replace into one function #84

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Conversation

rgbkrk
Copy link
Owner

@rgbkrk rgbkrk commented Aug 27, 2023

Keep interface similar to create_cell. Reasons:

  • we want to be able to update multiple properties
  • the model was very confused about how to do diff match patches, at least with GPT 3.5. that needs more experimentation between the format we return and what we accept
  • Switch from | to Union for Python 3.9

@rgbkrk rgbkrk changed the title merge update and replace into one function [noteable] merge update and replace into one function Aug 27, 2023
@rgbkrk rgbkrk merged commit 7f95087 into main Aug 27, 2023
@rgbkrk rgbkrk deleted the merge-updates branch August 27, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant