Validate lineIndex in RenderHelpBar for the diff view

Fixes #29
rgburke · Feb 2, 2018 · 5d8a501 · 5d8a501
1 parent a30318d
commit 5d8a501
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/cmd/grv/diff_view.go b/cmd/grv/diff_view.go
@@ -259,7 +259,7 @@ func (diffView *DiffView) renderEmptyView(win RenderWindow) (err error) {
 	return
 }
 
-// RenderHelpBar does nothing
+// RenderHelpBar renders help information for the diff view
 func (diffView *DiffView) RenderHelpBar(lineBuilder *LineBuilder) (err error) {
 	diffView.lock.Lock()
 	defer diffView.lock.Unlock()
@@ -274,12 +274,15 @@ func (diffView *DiffView) RenderHelpBar(lineBuilder *LineBuilder) (err error) {
 	}
 
 	lineIndex := diffView.viewPos.ActiveRowIndex()
-	line := diffLines.lines[lineIndex]
 
-	if line.lineType == dltDiffStatsFile {
-		RenderKeyBindingHelp(diffView.ViewID(), lineBuilder, []ActionMessage{
-			{action: ActionSelect, message: "Jump to file diff"},
-		})
+	if lineIndex < uint(len(diffLines.lines)) {
+		line := diffLines.lines[lineIndex]
+
+		if line.lineType == dltDiffStatsFile {
+			RenderKeyBindingHelp(diffView.ViewID(), lineBuilder, []ActionMessage{
+				{action: ActionSelect, message: "Jump to file diff"},
+			})
+		}
 	}
 
 	return