Fix loading issue with rake db:create on Rails 7.2 #418
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw in the issue that you had issues testing it. Could you test it manually at least ? And did it work properly ? |
|
I could not reproduce this. |
|
Let me try to put together a minimal app that can reproduce it. |
|
Will post back at the issue. |
Yep, I tested this locally and confirmed that it doesn't work on the latest (10.0) but does work on my branch. |
keithdoggett
approved these changes
Nov 7, 2024
|
@keithdoggett did you check what I posted on the issue? I was able to reproduce it with a multi-database configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415.
This issue seems to only happen if a connection isn't created during startup. Not sure why other representative apps don't have this problem - there might be something in an initializer that creates the connection before trying to run the rake task. But from a pure perspective, the postgis adapter file may not load by the time the db:create tasks runs.
This PR moves the registration to the topmost file, which seems to solve this problem.