updated kn-vsphere binary download

Closes: vmware-samples#1165
Signed-off-by: Robert Guske <[email protected]>

scripts/photon-settings.sh

@@ -59,12 +59,11 @@ mv kn-linux-amd64 /usr/local/bin/kn
 
 echo '> Downloading Kn vSphere CLI'
 KNATIVE_VSPHERE_VERSION=$(jq -r < ${VEBA_BOM_FILE} '.["knative-vsphere-cli"].version')
-KNATIVE_VSPHERE_NUMERIC_VERSION=$(echo ${KNATIVE_VSPHERE_VERSION} | sed 's/v//g')
-curl -L https://github.com/vmware-tanzu/sources-for-knative/releases/download/${KNATIVE_VSPHERE_VERSION}/kn-vsphere_${KNATIVE_VSPHERE_NUMERIC_VERSION}_Linux_x86_64.tar.gz -o /root/kn-vsphere_${KNATIVE_VSPHERE_NUMERIC_VERSION}_Linux_x86_64.tar.gz
-tar -zxvf /root/kn-vsphere_${KNATIVE_VSPHERE_NUMERIC_VERSION}_Linux_x86_64.tar.gz -C /root
-mv /root/kn-vsphere_${KNATIVE_VSPHERE_NUMERIC_VERSION}_Linux_x86_64/kn-vsphere /usr/local/bin/kn-vsphere
+curl -L https://github.com/vmware-tanzu/sources-for-knative/releases/download/${KNATIVE_VSPHERE_VERSION}/kn-vsphere_Linux_x86_64.tar.gz -o /root/kn-vsphere_Linux_x86_64.tar.gz
+tar -zxvf /root/kn-vsphere_Linux_x86_64.tar.gz -C /root
+mv /root/kn-vsphere_Linux_x86_64/kn-vsphere /usr/local/bin/kn-vsphere
 chmod +x /usr/local/bin/kn-vsphere
-rm -rf /root/kn-vsphere_${KNATIVE_VSPHERE_NUMERIC_VERSION}_Linux_x86_64*
+rm -rf /root/kn-vsphere_Linux_x86_64*
 
 echo '> Downloading YTT CLI'
 YTT_VERSION=$(jq -r < ${VEBA_BOM_FILE} '.["ytt-cli"].version')