-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codify new expansion release schedule #5916
base: master
Are you sure you want to change the base?
Conversation
Putting feedback here rather than discord, I think the doc itself is great as I've said there:
Do we think it's better if I don't approve this given that I helped write some of it, or am I fine to do so given that it's been met with approval from the problem squad (assuming the latter but want to clarify with a second opinion first) |
Co-authored-by: Bassoonian <[email protected]>
Added link to scehedule from website
I think you should not approve but don't feel strongly |
.github/pull_request_template.md
Outdated
@@ -6,6 +6,7 @@ | |||
|
|||
## Description | |||
<!--- Describe your changes in detail --> | |||
<!--- If you believe this PR qualifies as a "Big Feature" as defined in docs/schedule.md, please let a Maintainer know! --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scope's directory should also be updated
<!--- If you believe this PR qualifies as a "Big Feature" as defined in docs/schedule.md, please let a Maintainer know! --> | |
<!--- If you believe this PR qualifies as a "Big Feature" as defined in docs/team_procedures/schedule.md, please let a Maintainer know! --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still need to update the scope document URL
Co-authored-by: Eduardo Quezada <[email protected]>
Missing the other part of the review
Description
Add a document detailing the proposed expansion release schedule and process around Big Features
People who collaborated with me in this PR
@Pawkkie
Discord contact info
pkmnsnfrn