Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codify new expansion release schedule #5916

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

pkmnsnfrn
Copy link
Collaborator

Description

Add a document detailing the proposed expansion release schedule and process around Big Features

People who collaborated with me in this PR

@Pawkkie

Discord contact info

pkmnsnfrn

@Pawkkie
Copy link
Collaborator

Pawkkie commented Dec 31, 2024

Putting feedback here rather than discord, I think the doc itself is great as I've said there:


Do we think it's better if I don't approve this given that I helped write some of it, or am I fine to do so given that it's been met with approval from the problem squad (assuming the latter but want to clarify with a second opinion first)

@AlexOn1ine AlexOn1ine added the type: documentation Improvements or additions to documentation label Dec 31, 2024
docs/schedule.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
pkmnsnfrn and others added 2 commits December 31, 2024 08:13
Added link to scehedule from website
@pkmnsnfrn
Copy link
Collaborator Author

pkmnsnfrn commented Dec 31, 2024

  • Would suggest putting it in docs/team_procedures, and also moving scope.md to that folder. I think it makes sense to have all our developer-facing docs in one place. Perhaps that's not suitable though, feel free to ignore

Done

Done

Do we think it's better if I don't approve this given that I helped write some of it, or am I fine to do so given that it's been met with approval from the problem squad (assuming the latter but want to clarify with a second opinion first)

I think you should not approve but don't feel strongly

@@ -6,6 +6,7 @@

## Description
<!--- Describe your changes in detail -->
<!--- If you believe this PR qualifies as a "Big Feature" as defined in docs/schedule.md, please let a Maintainer know! -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope's directory should also be updated

Suggested change
<!--- If you believe this PR qualifies as a "Big Feature" as defined in docs/schedule.md, please let a Maintainer know! -->
<!--- If you believe this PR qualifies as a "Big Feature" as defined in docs/team_procedures/schedule.md, please let a Maintainer know! -->

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to update the scope document URL

@AsparagusEduardo AsparagusEduardo dismissed their stale review January 1, 2025 13:17

Missing the other part of the review

@pkmnsnfrn pkmnsnfrn requested a review from tertu-m January 2, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants