Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAP-16034] Core JMS client leaks temporary destination names #281

Open
wants to merge 1 commit into
base: 2.6.3.jbossorg-x
Choose a base branch
from
Open

[BEAP-16034] Core JMS client leaks temporary destination names #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...s-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,7 @@ public void addTemporaryQueue(final SimpleString queueAddress) {

public void removeTemporaryQueue(final SimpleString queueAddress) {
tempQueues.remove(queueAddress);
knownDestinations.remove(queueAddress);
}

public void addKnownDestination(final SimpleString address) {
Expand Down
47 changes: 47 additions & 0 deletions ...s-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TemporaryDestinationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
import javax.jms.TextMessage;
import javax.naming.NamingException;

import org.apache.activemq.artemis.api.core.SimpleString;
import org.apache.activemq.artemis.jms.client.ActiveMQConnection;
import org.apache.activemq.artemis.jms.tests.util.ProxyAssertSupport;
import org.junit.Test;

Expand Down Expand Up @@ -126,6 +128,51 @@ public void testTemporaryQueueBasic() throws Exception {
}
}

@Test
public void testTemporaryQueueLeak() throws Exception {
ActiveMQConnection conn = null;

try {
conn = (ActiveMQConnection) createConnection();

Session producerSession = conn.createSession(false, Session.AUTO_ACKNOWLEDGE);

Session consumerSession = conn.createSession(false, Session.AUTO_ACKNOWLEDGE);

TemporaryQueue tempQueue = producerSession.createTemporaryQueue();

MessageProducer producer = producerSession.createProducer(tempQueue);

MessageConsumer consumer = consumerSession.createConsumer(tempQueue);

conn.start();

final String messageText = "This is a message";

Message m = producerSession.createTextMessage(messageText);

producer.send(m);

TextMessage m2 = (TextMessage) consumer.receive(2000);

ProxyAssertSupport.assertNotNull(m2);

ProxyAssertSupport.assertEquals(messageText, m2.getText());

consumer.close();

tempQueue.delete();

ProxyAssertSupport.assertFalse(conn.containsKnownDestination(SimpleString.toSimpleString(tempQueue.getQueueName())));

ProxyAssertSupport.assertFalse(conn.containsTemporaryQueue(SimpleString.toSimpleString(tempQueue.getQueueName())));
} finally {
if (conn != null) {
conn.close();
}
}
}

/**
* http://jira.jboss.com/jira/browse/JBMESSAGING-93
*/
Expand Down