Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Fix build #810

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fuzz: Fix build #810

merged 1 commit into from
Jan 10, 2024

Conversation

nathaniel-brough
Copy link
Contributor

No description provided.

@nathaniel-brough
Copy link
Contributor Author

The last two builds for rhai have failed on oss-fuzz https://oss-fuzz-build-logs.storage.googleapis.com/index.html#rhai

This is my fault, I didn't properly git add things in my last PR and I also didn't configured the CI correctly, so the CI falsey reported that everything was ok. This should be main instead of master.

@nathaniel-brough
Copy link
Contributor Author

nathaniel-brough commented Jan 10, 2024

I tested all this locally and it's building fine again. I've also (hopefully) fixed up the oss-fuzz github action in #811

@schungx schungx merged commit 2f2c385 into rhaiscript:main Jan 10, 2024
39 checks passed
@schungx
Copy link
Collaborator

schungx commented Aug 27, 2024

@silvergasp For reasons I don't understand, the fuzz build has been failing for months now... and it seems that all other projects in OSS-Fuzz have been failing.

Can you possibly look into this matter?

@nathaniel-brough
Copy link
Contributor Author

Sure I'll take a look now.

@nathaniel-brough
Copy link
Contributor Author

Fixed in google/oss-fuzz#12409

Sorry I didn't catch this earlier, I don't receive notifications for failing builds.

@schungx
Copy link
Collaborator

schungx commented Aug 27, 2024

Strange that most of the projects have builds that are failing...

@schungx
Copy link
Collaborator

schungx commented Dec 12, 2024

@nathaniel-brough sorry to bother you... but some of the fuzz builds have been failing again... not sure what it is.

https://oss-fuzz-build-logs.storage.googleapis.com/log-c636c89b-2c30-40a9-910f-3739bae67bdd.txt

@nathaniel-brough
Copy link
Contributor Author

Looks like it's related to code-coverage reports. So fuzzing should still be working fine, it's just that code-coverage isn't being collected. Unless you are using the coverage reports you can safely ignore that build failure.

Never the less, I'll see if I can trouble shoot and get back to you.

@schungx
Copy link
Collaborator

schungx commented Dec 12, 2024

Great! No wonder it looks like all the builds are ok but then it still keeps telling me something is failing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants