Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #867 #874

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix #867 #874

merged 1 commit into from
May 15, 2024

Conversation

0byteme
Copy link
Contributor

@0byteme 0byteme commented May 14, 2024

try to fix #867

@0byteme 0byteme changed the title Fix can't compile features not_std and sync Fix can't compile features not_std and sync Closes #867 May 14, 2024
@0byteme 0byteme changed the title Fix can't compile features not_std and sync Closes #867 Fix #867 May 14, 2024
@schungx
Copy link
Collaborator

schungx commented May 15, 2024

Not sure about the code changes other than turning on the feature flag, do I'm running the tests.

@schungx schungx merged commit 521bedc into rhaiscript:main May 15, 2024
38 of 39 checks passed
@schungx
Copy link
Collaborator

schungx commented May 15, 2024 •
edited
Loading

Oops, shouldn't merge so quickly. There is a failed test that I didn't catch.

The sync feature doesn't build. It requires unwrap.

I'll fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The sync feature flag is not compatible with no_std
2 participants
@0byteme @schungx