Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile on thumbv6m #919

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix compile on thumbv6m #919

merged 1 commit into from
Sep 30, 2024

Conversation

chxry
Copy link
Contributor

@chxry chxry commented Sep 30, 2024

No description provided.

@schungx schungx merged commit 37011d2 into rhaiscript:main Sep 30, 2024
35 of 39 checks passed
@chxry
Copy link
Contributor Author

chxry commented Sep 30, 2024

critical-section isn't supported on most targets, using it should be under a feature flag.

@schungx
Copy link
Collaborator

schungx commented Sep 30, 2024

Oops. I merged it already.

Maybe I should reverse it?

@schungx
Copy link
Collaborator

schungx commented Sep 30, 2024

But if it is available on a low end ARM, I suppose it is universal enough?

@chxry
Copy link
Contributor Author

chxry commented Sep 30, 2024

It only really exists on embedded systems, that change breaks building no_std_test. I've fixed it here and can create a new PR.

@schungx
Copy link
Collaborator

schungx commented Oct 1, 2024

Pls do. I don't do embedded and so I cannot test myself.

@chxry chxry mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chxry @schungx