-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an X server for X11 sessions #16
base: main
Are you sure you want to change the base?
Conversation
I'll test it, might be a day or two before I get around to it. From a quick glance, I'm not sure if Lightdm & co also put a lot of effort into passing session status to the X server. I'm not 100% sure what said status is actually needed for though, so let's see! |
Hrm, The two source different configuration files for the running X server, because Ultimately this boils down to I've spent some time delving into the details of how lightdm/gdm actually launch to see what a display manager is actually supposed to do so I can suggest (and perhaps implement myself) an alternate approach, but haven't yet fully figured it out. Regardless, this has definitely convinced me even more to get rid of my X sessions as soon as possible. |
src/sysutil.rs
Outdated
let mut sessions = Self::init_sessions( | ||
XSESSION_DIRS, | ||
"xsessions", | ||
&vec!["startx".into(), "/bin/env".into()], | ||
)?; | ||
sessions.extend(Self::init_sessions( | ||
WAYLAND_SESSION_DIRS, | ||
"wayland-sessions", | ||
&Vec::new(), | ||
)?); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to look at would be adding support for running e.g. Cage and starting Xwayland rootful to use X sessions :)
Just dropping my 2 cents here: From what I was able to understand, |
What distro are you using? Arch doesn't have that file. |
I'm using Debian testing. The session file is
|
- Prepend `startx /bin/env` to X11 session commands - Separate `SESSION_DIRS` environment variable into `WAYLAND_SESSION_DIRS` and `XSESSION_DIRS`, since there's no way of knowing this from the session file itself
`SESSION_DIRS` has been removed, so have to bump version.
This resolves #15 by prepending
startx /bin/env
to X11 session commands, to start an X server for an X11 session. Note that this assumes the existence of thestartx
and/bin/env
commands.Further, since this is only to be done for X11 sessions, this PR separates the
SESSION_DIRS
environment variable intoWAYLAND_SESSION_DIRS
andXSESSION_DIRS
, since there's no way of knowing this from the session file itself.@TLATER, since you seem to be a lot more familiar with this than me, can you test this and see if it works for your cases (and any other potential ones)?
EDIT: Also resolves #31.