Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding timeout to WakeStreamingSatellite event_from_mic to keep it from getting stuck #211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Graimalkin
Copy link

Why:

Right now, if you are NOT running VAD with your satellite, it can get stuck in WakeStreamingSatellite event_from_mic.

I'm running multiple satellites in Docker containers with mic / playback / satellite containers on them, no VAD. ( In fact, there is no VAD in the Docker container build, but that's a problem for tomorrow. )

What:

Added in a timeout to WakeStreamingSatellite event_from_mic based on the timeout in VadStreamingSatellite event_from_mic. I figured we should be doing about the same thing there.

The one caveat being this is based on the setting self.settings.vad.wake_word_timeout. I didn't feel like adding in a new setting. Let me know if you want that setting genericized or something.

Testing:

I've had a variant of this container running stably for about a week now. No getting stuck. 🙌

@florian-asche
Copy link

About the Docker problem, i build a really great image with everything in it: https://github.com/florian-asche/wyoming-satellite/tree/feat-add-ghr-support

I am currently working on the docker-compose file, some documentation and fine tuning. Yeah but i got stuck with the issue 237.

Is the problem you described here the same like in #237?

@Graimalkin
Copy link
Author

Graimalkin commented Nov 26, 2024

Yeah, it is.

Basically, if you have the VAD components installed, there is a 5 second inactivity timeout by default.

Without VAD installed, there is no such timeout. So without VAD, the system can get stuck in a constantly listening state, even if everything is quiet.

This fix adds that timeout to the non-VAD setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants