Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBM NVMeOF Changes #132

Open
wants to merge 4 commits into
base: rhel-9-main
Choose a base branch
from

Conversation

AvnishChouhan-IBM
Copy link
Contributor

The following changes will make grub support NVMeOF.

This patch enables the fcp-targets and fcp-luns methods which are
responsible to get WWPNs and LUNs for fibre channel devices.

Those methods are specially necessary if the boot directory and grub
installation are in different FCP disks, allowing the dev_iterate()
to find the WWPNs and LUNs when called by searchfs.uuid tool.

Signed-off-by: Diego Domingos <[email protected]>
Signed-off-by: Avnish Chouhan <[email protected]>
Usually grub will parse the PFW arguments by searching for the first occurence of the character ':'.
However, we can have this char more than once on NQN.
This patch changes the logic to find the last occurence of this char so we can get the proper values
for NVMeoFC

Signed-off-by: Diego Domingos <[email protected]>
Signed-off-by: Avnish Chouhan <[email protected]>
This patch implements the functions to scan and discovery of NVMeoFC.

Signed-off-by: Diego Domingos <[email protected]>
Signed-off-by: Avnish Chouhan <[email protected]>
This patch add code to enable the translation of logical devices to the of NVMeoFC paths.

Signed-off-by: Diego Domingos <[email protected]>
Signed-off-by: Avnish Chouhan <[email protected]>
@nfrayer nfrayer requested review from vathpela and nfrayer August 21, 2023 15:38
@AvnishChouhan-IBM
Copy link
Contributor Author

Hi RedHat, Any update on the patch reviews?
Thank you!

@nfrayer
Copy link
Contributor

nfrayer commented Apr 26, 2024

Hi Avnish,

It seems your patches are still not merged upstream.
Can you ping Daniel Kiper (grub upstream maintainer) and see if he can prioritize them ?
We do prefer to wait for patches to be merged upstream first to avoid issues.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants