Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub-mkstandalone: reduce sharp edges #148

Open
wants to merge 1 commit into
base: fedora-39
Choose a base branch
from

Conversation

phip1611
Copy link

@phip1611 phip1611 commented Nov 29, 2023

It is a major foot gun that grub-mkstandalone silently drops files. As a first step, we can improve documentation and add warn messages.

PS: I'm aware that this is a RO mirror. I just wanted to save this for better google-ability for others. I'm going to contribute this the regular way soon, hopefully. (Guidance, please?) Or can one you, the maintainers, just copy, paste, and apply the patch?

PPS: I have to build and test this locally as well (WIP).

@phip1611 phip1611 force-pushed the grub-mkstandalone-usability branch from 9a6ec1c to 0f06cdb Compare November 29, 2023 14:48
It is a major foot gun that grub-mkstandalone silently drops files.
As a first step, we can improve documentation and add warn messages.

Signed-off-by: Philipp Schuster <[email protected]>
@phip1611 phip1611 force-pushed the grub-mkstandalone-usability branch from 0f06cdb to 0c0c9d7 Compare November 29, 2023 14:57
@nfrayer
Copy link
Contributor

nfrayer commented Dec 1, 2023

@phip1611 You can send your patch upstream first by following the steps on https://www.gnu.org/software/grub/grub-development.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants