Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contacts-Endpunkt erweitern #4

Merged
merged 27 commits into from
Jul 1, 2019
Merged

Contacts-Endpunkt erweitern #4

merged 27 commits into from
Jul 1, 2019

Conversation

rheinwerk-mp
Copy link

Die wesentlichen Änderungen:

rheinwerk-mp and others added 12 commits June 27, 2019 11:25
@rheinwerk-mp
Ensured consistent naming by renaming methods and marking former meth…
2fd8e69 
…ods as deprecated. Also changed docstrings to use imperative.
@rheinwerk-mp
Added two endpoints
1c47a3f
@rheinwerk-mp
Merge branch 'feature/contact_endpoints' into feature/INC-1791-2
9cd7b6d
@rheinwerk-mp
Ensured consistent naming by renaming methods and marking former meth…
1f5cb21 
…ods as deprecated
@W1ldPo1nter @rheinwerk-mp
Added a fixture for a mocked connection to simplify tests using mock …
7470902 
…requests
@rheinwerk-mp
Renamed parameters
0a8c75d
@rheinwerk-mp
Refactored to use the try-except in both cases, if data is bytes or i…
dc4c784 
…f data is string
@rheinwerk-mp
Removed return since the endpoint returns "SUCCESS" as string
a663470
@rheinwerk-mp
Made data optional and unfolded list for better assertion per argument
bc345fe
@rheinwerk-mp
Moved default_batch_properties for class attribute for better testabi…
a8b8224 
…lity
@rheinwerk-mp
Changed currents tests to using the mock client
d784567
@rheinwerk-mp
Added testing for passing the extra_properties as string or as list
babd344
@rheinwerk-mp rheinwerk-mp changed the title INC-1791-2 Contacts-Endpunkt erweitern Jun 27, 2019
W1ldPo1nter
W1ldPo1nter requested changes Jun 28, 2019
View reviewed changes
Copy link

@W1ldPo1nter W1ldPo1nter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generell sollte auch geschaut werden, wie set_response genutzt wird: es ist eigentlich dafür da, den rohen (=String) Response zu setzen - hier wird aber meist schon ein fertiges dict o.ä. verwendet (ich habe in meinem Branch auch noch einen solchen Fehler korrigiert). Ggf. also an den entsprechenden Stellen einfach noch ein json.dumps(...) drum herum bauen.

hubspot3/contacts.py Show resolved Hide resolved
hubspot3/test/test_contacts.py Outdated Show resolved Hide resolved
hubspot3/test/test_contacts.py Show resolved Hide resolved
hubspot3/test/test_contacts.py Outdated Show resolved Hide resolved
hubspot3/test/test_contacts.py Outdated Show resolved Hide resolved
@W1ldPo1nter W1ldPo1nter self-requested a review July 1, 2019 09:39
W1ldPo1nter
W1ldPo1nter requested changes Jul 1, 2019
View reviewed changes
hubspot3/test/test_contacts.py Outdated Show resolved Hide resolved
hubspot3/test/conftest.py Outdated Show resolved Hide resolved
hubspot3/test/conftest.py Show resolved Hide resolved
hubspot3/test/conftest.py Outdated Show resolved Hide resolved
@W1ldPo1nter W1ldPo1nter merged commit b8e1c34 into feature/contact_endpoints Jul 1, 2019
@rheinwerk-mp rheinwerk-mp deleted the feature/INC-1791-2 branch July 1, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W1ldPo1nter W1ldPo1nter W1ldPo1nter approved these changes

Assignees

@W1ldPo1nter W1ldPo1nter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rheinwerk-mp @W1ldPo1nter