GitCommitBear: Block invalid email addresses #6

rhemon · 2017-07-23T19:35:24Z

Uses validate_email to check invalid email
addresses in git commit message.

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Uses validate_email to check invalid email addresses in git commit message. Fixes coala#1791

rhemon · 2017-07-24T02:14:22Z

Comment on f1548c1.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'trying'

GitCommitBear, severity NORMAL, section commit.

rhemon · 2017-07-24T02:37:54Z

Comment on f1548c1.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'trying'

GitCommitBear, severity NORMAL, section commit.

rhemon · 2017-07-24T03:12:32Z

Comment on f1548c1.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'trying'

GitCommitBear, severity NORMAL, section commit.

rhemon · 2017-07-24T03:34:28Z

Comment on f1548c1.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'trying'

GitCommitBear, severity NORMAL, section commit.

rhemon · 2017-07-24T03:34:46Z

Comment on ec558ce.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'removing'

GitCommitBear, severity NORMAL, section commit.

rhemon · 2017-07-24T05:13:29Z

Comment on f1548c1.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'trying'

GitCommitBear, severity NORMAL, section commit.

rhemon · 2017-07-24T05:13:47Z

Comment on ec558ce.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'removing'

GitCommitBear, severity NORMAL, section commit.

rhemon · 2017-07-24T05:13:59Z

bears/vcs/git/GitCommitBear.py

+                for email in re.findall(r'\w+@+\w+\.+\w*', line):
+                    if is_email(email, diagnose=True, check_dns=True).ERROR_CODES:
+                        invalid_emails = True
+                        result_message += ' ' + email + '\n'


Line is longer than allowed. (82 > 79)

LineLengthBear, severity NORMAL, section linelength.

rhemon · 2017-07-24T05:14:00Z

bears/vcs/git/GitCommitBear.py

@@ -236,6 +239,8 @@ def check_body(self, body,
                                    expressions in this list will be ignored.
        :param body_regex:          If provided, checks the presence of regex
                                    in the commit body.
+        :param verify_email:         Checks validity of emails in commit body if
+                                    present.


Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section linelength.

rhemon · 2017-07-24T05:14:01Z

tests/vcs/git/GitCommitBearTest.py

+        # Testing if check recognises invalid emails
+        self.git_commit('Shortlog\n\n'
+                        'A valid email [email protected]\n'
+                        'An invalid email [email protected]\n'


Line is longer than allowed. (87 > 79)

LineLengthBear, severity NORMAL, section linelength.

rhemon · 2017-07-24T05:14:01Z

tests/vcs/git/GitCommitBearTest.py

+        # Testing if check recognises invalid emails
+        self.git_commit('Shortlog\n\n'
+                        'A valid email [email protected]\n'
+                        'An invalid email [email protected]\n'


E501 line too long (87 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

rhemon · 2017-07-24T05:14:02Z

bears/vcs/git/GitCommitBear.py

+                for email in re.findall(r'\w+@+\w+\.+\w*', line):
+                    if is_email(email, diagnose=True, check_dns=True).ERROR_CODES:
+                        invalid_emails = True
+                        result_message += ' ' + email + '\n'


E501 line too long (82 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

rhemon · 2017-07-24T05:14:03Z

bears/vcs/git/GitCommitBear.py

@@ -236,6 +239,8 @@ def check_body(self, body,
                                    expressions in this list will be ignored.
        :param body_regex:          If provided, checks the presence of regex
                                    in the commit body.
+        :param verify_email:         Checks validity of emails in commit body if
+                                    present.


E501 line too long (80 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

rhemon · 2017-07-26T05:51:12Z

Comment on f1548c1.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'trying'

GitCommitBear, severity NORMAL, section commit.

rhemon · 2017-07-26T05:51:30Z

Comment on ec558ce.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'removing'

GitCommitBear, severity NORMAL, section commit.

rhemon · 2017-07-26T05:51:43Z

tests/vcs/git/GitCommitBearTest.py

+        # Testing if check recognises invalid emails
+        self.git_commit('Shortlog\n\n'
+                        'A valid email [email protected]\n'
+                        'An invalid email [email protected]\n'


E501 line too long (87 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

rhemon · 2017-07-26T05:51:44Z

bears/vcs/git/GitCommitBear.py

+                for email in re.findall(r'\w+@+\w+\.+\w*', line):
+                    if is_email(email, diagnose=True, check_dns=True).ERROR_CODES:
+                        invalid_emails = True
+                        result_message += ' ' + email + '\n'


E501 line too long (82 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

rhemon · 2017-07-26T05:51:45Z

bears/vcs/git/GitCommitBear.py

@@ -236,6 +239,8 @@ def check_body(self, body,
                                    expressions in this list will be ignored.
        :param body_regex:          If provided, checks the presence of regex
                                    in the commit body.
+        :param verify_email:         Checks validity of emails in commit body if
+                                    present.


E501 line too long (80 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

rhemon · 2017-07-26T05:51:45Z

tests/vcs/git/GitCommitBearTest.py

+        # Testing if check recognises invalid emails
+        self.git_commit('Shortlog\n\n'
+                        'A valid email [email protected]\n'
+                        'An invalid email [email protected]\n'


Line is longer than allowed. (87 > 79)

LineLengthBear, severity NORMAL, section linelength.

rhemon · 2017-07-26T05:51:46Z

bears/vcs/git/GitCommitBear.py

+                for email in re.findall(r'\w+@+\w+\.+\w*', line):
+                    if is_email(email, diagnose=True, check_dns=True).ERROR_CODES:
+                        invalid_emails = True
+                        result_message += ' ' + email + '\n'


Line is longer than allowed. (82 > 79)

LineLengthBear, severity NORMAL, section linelength.

rhemon · 2017-07-26T05:51:47Z

bears/vcs/git/GitCommitBear.py

@@ -236,6 +239,8 @@ def check_body(self, body,
                                    expressions in this list will be ignored.
        :param body_regex:          If provided, checks the presence of regex
                                    in the commit body.
+        :param verify_email:         Checks validity of emails in commit body if
+                                    present.


Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section linelength.

rhemon · 2017-07-26T05:52:00Z

bears/vcs/git/GitCommitBear.py

@@ -260,6 +268,25 @@ def check_body(self, body,
                               'Commit body lines should not exceed {} '
                               'characters.'.format(body_line_length))



E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

rhemon · 2017-07-26T05:52:01Z

bears/vcs/git/GitCommitBear.py

+        :param valid_email_check:   If True, it checks if emails are in valid
+                                    format or not
+        :param email_dns_check:     If True, it checks if domains in the emails
+                                    are valid or not
        """
        if len(body) == 0:


E225 missing whitespace around operator'

PycodestyleBear (E225), severity NORMAL, section autopep8.

rhemon · 2017-07-26T05:52:01Z

bears/vcs/git/GitCommitBear.py

+        :param valid_email_check:   If True, it checks if emails are in valid
+                                    format or not
+        :param email_dns_check:     If True, it checks if domains in the emails
+                                    are valid or not
        """


E225 missing whitespace around operator'

PycodestyleBear (E225), severity NORMAL, section autopep8.

rhemon · 2017-07-26T05:52:02Z

bears/vcs/git/GitCommitBear.py

@@ -260,6 +268,25 @@ def check_body(self, body,
                               'Commit body lines should not exceed {} '
                               'characters.'.format(body_line_length))



The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/vcs/git/GitCommitBear.py +++ b/bears/vcs/git/GitCommitBear.py @@ -280,7 +280,7 @@ # look up dns if email_dns_check and email_check: email_check = not is_email(email, diagnose=True, - check_dns=True).ERROR_CODES + check_dns=True).ERROR_CODES if not email_check: invalid_emails = True result_message += ' ' + email + '\n'

rhemon · 2017-07-26T05:52:03Z

bears/vcs/git/GitCommitBear.py

+        :param valid_email_check:   If True, it checks if emails are in valid
+                                    format or not
+        :param email_dns_check:     If True, it checks if domains in the emails
+                                    are valid or not
        """


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/vcs/git/GitCommitBear.py +++ b/bears/vcs/git/GitCommitBear.py @@ -274,8 +274,8 @@ for line in body: for email in re.findall(r'\S*@\S*', line): email_check = re.match(r"(^[a-zA-Z0-9_.+-]" - +r"+@[a-zA-Z0-9-]+\." - +r"[a-zA-Z0-9-.]+$)", email) + + r"+@[a-zA-Z0-9-]+\." + + r"[a-zA-Z0-9-.]+$)", email) # if eamil do not match regex there is no need to # look up dns if email_dns_check and email_check:

GitCommitBear: Block invalid email addresses

bbd70e6

Uses validate_email to check invalid email addresses in git commit message. Fixes coala#1791

rhemon added pending review size/S review carefully! size/M and removed size/S labels Jul 23, 2017

rhemon added 3 commits July 24, 2017 01:44

set sudo false

58f2a84

sudo false doesn't work

1808c3d

trying random stuff

f1548c1

set debug to true

5f05855

rhemon added size/L and removed size/M labels Jul 24, 2017

update apt-get

76d5ecd

removing sudo

ec558ce

rhemon added 2 commits July 24, 2017 09:45

add back sudo

493c74e

use pyisemail instead of validate_email

ab71c60

rhemon commented Jul 24, 2017

View reviewed changes

works with this

17b572b

rhemon added size/XL and removed size/L labels Jul 26, 2017

options to check dns

12c1ae2

rhemon commented Jul 26, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitCommitBear: Block invalid email addresses #6

GitCommitBear: Block invalid email addresses #6

rhemon commented Jul 23, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon Jul 24, 2017

rhemon Jul 24, 2017

rhemon Jul 24, 2017

rhemon Jul 24, 2017

rhemon Jul 24, 2017

rhemon Jul 24, 2017

rhemon commented Jul 26, 2017

rhemon commented Jul 26, 2017

rhemon Jul 26, 2017

rhemon Jul 26, 2017

rhemon Jul 26, 2017

rhemon Jul 26, 2017

rhemon Jul 26, 2017

rhemon Jul 26, 2017

rhemon Jul 26, 2017

rhemon Jul 26, 2017

rhemon Jul 26, 2017

rhemon Jul 26, 2017

rhemon Jul 26, 2017

		@@ -260,6 +268,25 @@ def check_body(self, body,
		'Commit body lines should not exceed {} '
		'characters.'.format(body_line_length))

GitCommitBear: Block invalid email addresses #6

Are you sure you want to change the base?

GitCommitBear: Block invalid email addresses #6

Conversation

rhemon commented Jul 23, 2017

Checklist

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

rhemon commented Jul 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhemon commented Jul 26, 2017

rhemon commented Jul 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment