Merge pull request #1 from rhinestonewtf/fix/remediations

fix: remediation in nr of executions
rhinestonewtf · Jul 4, 2024 · 20be051 · 20be051
2 parents 99c4540 + 2b5f08e
commit 20be051
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/SchedulingBase.sol b/src/SchedulingBase.sol
@@ -100,12 +100,16 @@ abstract contract SchedulingBase is ERC7579ExecutorBase {
         uint256 jobId = accountJobCount[account] + 1;
         accountJobCount[account]++;
 
+        // prevent user from supplying an invalid number of execution (0)
+        uint16 nrOfExecutions = uint16(bytes2(orderData[6:8]));
+        if (nrOfExecutions == 0) revert InvalidExecution();
+
         executionLog[account][jobId] = ExecutionConfig({
             numberOfExecutionsCompleted: 0,
             isEnabled: true,
             lastExecutionTime: 0,
             executeInterval: uint48(bytes6(orderData[0:6])),
-            numberOfExecutions: uint16(bytes2(orderData[6:8])),
+            numberOfExecutions: nrOfExecutions,
             startDate: uint48(bytes6(orderData[8:14])),
             executionData: orderData[14:]
         });