refactor: remove account dependencies #161
Open
+3,686
−453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highskore
changed the title
highskore
changed the title
|
@kopy-kat a few issues:
|
|
Should we remove registry dep too? |
done but the 7702 compatibility change added to 7579 ref requries ^0.8.24 for tstore too (we can precompile this tho), but the 4337 repo is ^0.8.23 too maybe lets just keep it >=0.8.24 <0.9.0 ? |
|
Yeah that’s mid, maybe we remove the 7579 impl too - but yeah maybe we need to stay higher than 0.8.24 |
7579 ref is removed, bumped solc to 0.8.24 >= All in all this pr removes the kernel, safe7579, 7579ref and registry dependecies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #158 to make #160 work