Adapt CI on RHEL-9 branch #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to add this back when CentOS Stream for 9 will be available.
Change where to get container image and solve COPR.
Dockerfiles were from F34. We want to leave them as close as possible but still we need to change things like base container etc. Main difference here is that we don't need to have ELN support in RHEL-9 so remove these parts from Dockerfiles to simplify it.
We don't using this approach anymore. We are now connect VMs to the GitHub and not just containers. This is one layer of complexity now which doesn't give us any benefits.
This is in general good practice.
We need to change this later to follow GA release.
Triggers other than `pull_request` and `pull_request_target` are working only from the main branch and there is no benefit of having them here.
Use GitHub environment to gate the changes going in. We are using the same solution on master branch now. Use our self-hosted runners with access to required sources.
VladimirSlavik
approved these changes
May 4, 2021
Comment on lines
-44
to
-48
| # see https://github.com/martinpitt/anaconda/settings/actions/add-new-runner | ||
| RUN mkdir actions-runner && cd actions-runner && \ | ||
| URL_BASE=https://github.com/actions/runner/releases && \ | ||
| LATEST_VER=$(basename $(curl -Ls -o /dev/null -w '%{url_effective}' $URL_BASE/latest)) && \ | ||
| curl -L "$URL_BASE/download/$LATEST_VER/actions-runner-linux-x64-${LATEST_VER#v}.tar.gz" | tar xvz |
There was a problem hiding this comment.
We should probably do this for the other branches, too?
There was a problem hiding this comment.
Correct. However, are we finished with the migration out of the github-ci workflow?
| @@ -16,6 +16,7 @@ RUN set -e; \ | |||
| rpm-build; \ | |||
| curl -L https://raw.githubusercontent.com/rhinstaller/anaconda/${git_branch}/anaconda.spec.in | sed 's/@PACKAGE_VERSION@/0/; s/@PACKAGE_RELEASE@/0/; s/%{__python3}/python3/' > /tmp/anaconda.spec; \ | |||
| rpmspec -q --buildrequires /tmp/anaconda.spec | xargs -d '\n' dnf install -y; \ | |||
| dnf clean all; \ | |||
poncovka
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt rhel-9 branch for running tests. This patch set is doing this.
Test run.