webui: add a logo to the header #5046
Conversation
adamkankovsky
commented
Aug 15, 2023
•
adamkankovsky
commented
KKoukiou
force-pushed
the
webui-branding-logo
branch
from
df3bbb2
to
0297eb2
Compare
There was a problem hiding this comment.
This looks good to me.
My only concern is if this adds vertical space to the header, as the logo is probably taller than the text. If it doesn't, then that's great! If it does, we might need to do something like one of the following:
- logo would either need a vertical margin to compensate, like
margin-block: -0.5rem;or something like that - the padding for the heading would need to be adjusted
- the position would need to be changed (like absolute with a 2.5rem (size + gap)
- use
backgroundfor sizing
(Using absolute positioning would be the hackiest approach.)
But: Hopefully the logo doesn't affect the size of the heading!
|
@garrett it does not affect the size of the heading. |
|
/kickstart-test --waive webui |
There was a problem hiding this comment.
I don't think we should do it like this (shipping a symlink, that will be a dead symlink on boot.iso). Instead I think we should just bundle the icon (until Lorax is fixed not to remove it on boot.iso), which would make this change more robust & simpler code wise.
| @@ -64,6 +66,7 @@ export const AnacondaHeader = ({ beta, title, reportLinkURL }) => { | |||
| return ( | |||
| <PageSection variant={PageSectionVariants.light}> | |||
| <Flex spaceItems={{ default: "spaceItemsSm" }} alignItems={{ default: "alignItemsCenter" }}> | |||
| {!isBootIso && <span className="logo" />} | |||
There was a problem hiding this comment.
I think we should just make sure the icon is available on both boot.iso and Live image, even if we have to bundle it for now.
There was a problem hiding this comment.
weldr/lorax#1341 is now merged so in a few days there will no be any broken symlink.
So your concern will be solved.
|
Note, packages aren't allowed to bundle logos. All trademarks have to be put in the package that has Licensed only for approved usage, see COPYING for details. for the license (fedora-logos). |
|
Just tested - not yet available on boot.iso |
KKoukiou
force-pushed
the
webui-branding-logo
branch
from
0297eb2
to
adfbc2a
Compare
KKoukiou
force-pushed
the
webui-branding-logo
branch
from
adfbc2a
to
208c88f
Compare
Co-authored-by: Katerina Koukiou <[email protected]>
KKoukiou
force-pushed
the
webui-branding-logo
branch
from
208c88f
to
208d125
Compare
|
/kickstart-test --waive webui |
KKoukiou
changed the title
