-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url handlers #5059
Url handlers #5059
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# url-handlers/Makefile.am for anaconda | ||
# | ||
# Copyright (C) 2023 Red Hat, Inc. | ||
# | ||
# This program is free software; you can redistribute it and/or modify | ||
# it under the terms of the GNU Lesser General Public License as published | ||
# by the Free Software Foundation; either version 2.1 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# This program is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU Lesser General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU Lesser General Public License | ||
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
desktopdir = $(datadir)/applications | ||
dist_desktop_DATA = anaconda-storage.desktop | ||
|
||
MAINTAINERCLEANFILES = Makefile.in |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
[Desktop Entry] | ||
Name=Anaconda Storage | ||
Exec=blivet-gui | ||
Type=Application | ||
MimeType=x-scheme-handler/anaconda-storage; | ||
NoDisplay=true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -423,7 +423,13 @@ const ModifyStorageButton = ({ isBootIso }) => { | |
} | ||
|
||
return ( | ||
<Button variant="link" icon={<WrenchIcon />} onClick={() => cockpit.spawn(["blivet-gui"])}> | ||
<Button variant="link" icon={<WrenchIcon />} | ||
onClick={() => { | ||
const onBeforeUnload = window.onbeforeunload; | ||
window.onbeforeunload = null; | ||
window.location.href = "anaconda-storage:"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will it have the correct address afterwards? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's not redirecting away from anaconda if that's what you mean. It's akin to having a "mailto:" link in a web page. it just fires up the email client^W^Wblivet |
||
window.onbeforeunload = onBeforeUnload; | ||
}}> | ||
{_("Modify storage")} | ||
</Button> | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this appear anywhere visible to the user? I.e. does this need i18n?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, it's NoDisplay=true, shouldn't show up anywhere in the ui