Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove files as per-move of the Web UI to it's own repository #5304

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Nov 8, 2023

Code and tests: https://github.com/rhinstaller/anaconda-webui
Localization sync repo with weblate: https://github.com/rhinstaller/anaconda-webui-l10n

Remaining in this repo are the workflows which run the e2e tests and also the workflows to build the ISOs with the webui. These need to be moved / adjusted as well, but it's not trivial, so it need to be a followup to not block the switch to new repository.

@github-actions github-actions bot added infrastructure Changes affecting mostly infrastructure documentation webui f40 labels Nov 8, 2023
@KKoukiou KKoukiou force-pushed the anaconda-webui-split branch 5 times, most recently from cf83b3f to d2e601a Compare November 8, 2023 13:05
@KKoukiou KKoukiou marked this pull request as ready for review November 8, 2023 13:16
@KKoukiou KKoukiou added the blocked Don't merge this pull request! label Nov 8, 2023
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me based on the code removals.

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

@KKoukiou KKoukiou removed the blocked Don't merge this pull request! label Nov 13, 2023
@KKoukiou KKoukiou force-pushed the anaconda-webui-split branch 2 times, most recently from 29ccb0e to df80776 Compare November 13, 2023 08:45
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, it looks good to me. Thank you!

docs/commit-log.rst Outdated Show resolved Hide resolved
…tory

Code and tests: https://github.com/rhinstaller/anaconda-webui
Localization sync repo with weblate: https://github.com/rhinstaller/anaconda-webui-l10n

Remaining in this repo are the workflows which run the e2e tests and
also the workflows to build the ISOs with the webui.
These need to be moved / adjusted as well, but it's not trivial, so it need to be a
followup to not block the switch to new repository.
@VladimirSlavik VladimirSlavik removed the infrastructure Changes affecting mostly infrastructure label Nov 13, 2023
@rhinstaller rhinstaller deleted a comment from github-actions bot Nov 13, 2023
@rhinstaller rhinstaller deleted a comment from github-actions bot Nov 13, 2023
@rhinstaller rhinstaller deleted a comment from github-actions bot Nov 13, 2023
@rhinstaller rhinstaller deleted a comment from github-actions bot Nov 13, 2023
@rhinstaller rhinstaller deleted a comment from github-actions bot Nov 13, 2023
@rhinstaller rhinstaller deleted a comment from github-actions bot Nov 13, 2023
@rhinstaller rhinstaller deleted a comment from github-actions bot Nov 13, 2023
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks correct to me. Lots of details solved that I thought would be overlooked.

@@ -50,129 +50,3 @@ Create your repository locally and upload that.
$ scp -r * <fedora_username>:fedorapeople.org:/project/anaconda/repos/anaconda_fixup_repo

After the above is done, everything should be fixed and Packit should work again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The information in this file is only removed (it does not exist in the new repo). I don't know if it's entirely invalid now, just taking note so it can be found later if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You 're right. I will create a Jira for followups and include this one.

@KKoukiou KKoukiou merged commit c9e9f96 into rhinstaller:master Nov 16, 2023
11 of 13 checks passed
@KKoukiou KKoukiou deleted the anaconda-webui-split branch November 16, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants