-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove files as per-move of the Web UI to it's own repository #5304
Conversation
cf83b3f
to
d2e601a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me based on the code removals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. :)
29ccb0e
to
df80776
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, it looks good to me. Thank you!
…tory Code and tests: https://github.com/rhinstaller/anaconda-webui Localization sync repo with weblate: https://github.com/rhinstaller/anaconda-webui-l10n Remaining in this repo are the workflows which run the e2e tests and also the workflows to build the ISOs with the webui. These need to be moved / adjusted as well, but it's not trivial, so it need to be a followup to not block the switch to new repository.
df80776
to
32a8e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks correct to me. Lots of details solved that I thought would be overlooked.
@@ -50,129 +50,3 @@ Create your repository locally and upload that. | |||
$ scp -r * <fedora_username>:fedorapeople.org:/project/anaconda/repos/anaconda_fixup_repo | |||
|
|||
After the above is done, everything should be fixed and Packit should work again. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The information in this file is only removed (it does not exist in the new repo). I don't know if it's entirely invalid now, just taking note so it can be found later if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You 're right. I will create a Jira for followups and include this one.
Code and tests: https://github.com/rhinstaller/anaconda-webui
Localization sync repo with weblate: https://github.com/rhinstaller/anaconda-webui-l10n
Remaining in this repo are the workflows which run the e2e tests and also the workflows to build the ISOs with the webui. These need to be moved / adjusted as well, but it's not trivial, so it need to be a followup to not block the switch to new repository.