Add "class" to password_policies

[Rtoax]

For example:

    Password    Class
    1234        1
    1abc        2
    1aBC        3
    1aB!        4

[pep8speaks]

Hello @Rtoax! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file pyanaconda/core/constants.py:

Line 198:24: E203 whitespace before ':'
Line 198:100: E501 line too long (121 > 99 characters)
Line 199:26: E203 whitespace before ':'
Line 199:100: E501 line too long (122 > 99 characters)

• In the file pyanaconda/input_checking.py:

Line 418:100: E501 line too long (109 > 99 characters)

Comment last updated at 2023-11-23 08:19:17 UTC

[KKoukiou]

@Rtoax thanks for the PR.

Can you please describe the use case for this new feature? How does the class differs from the quality? Did not go through the code but I would like to see this in the commit message these information.

It's also missing tests; Probably to be inserted at: tests/unit_tests/pyanaconda_tests/modules/common/test_policy.py

Before you put more effort on this give the team a short time to react on the desirability of this feature.

CC @poncovka any thoughts?

[Rtoax]

@Rtoax thanks for the PR.

Can you please describe the use case for this new feature? How does the class differs from the quality? Did not go through the code but I would like to see this in the commit message these information.

It's also missing tests; Probably to be inserted at: tests/unit_tests/pyanaconda_tests/modules/common/test_policy.py

Before you put more effort on this give the team a short time to react on the desirability of this feature.

CC @poncovka any thoughts?

This commit just do the same thing like libpwquality's minclass in /etc/security/pwquality.conf

How/What to use/show

[KKoukiou]

I see the libpwquality has a configuration option for the mean class. We are already using this library for validation password quality, and the checks for length are passed through that.

I see minclass is a configurable option in the pwquality library, so it looks like more reasonable to work on that direction.

I see the checks for minlen are on this direction so probably the logic can be stolen from that. How do you see this? Are you satisfied with this solution direction?

[KKoukiou]

I think we need to reuse the libpwquality class configuration option here:
https://manpages.ubuntu.com/manpages/jammy/man5/pwquality.conf.5.html

See minclass

[KKoukiou]

Closing because of long time inactivity. If you 're still actively interested feel free to ping to reopen.