Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timezone: for kickstart allow also timezones not offered by GUI #5345

Merged
merged 1 commit into from
Dec 13, 2023
Merged

timezone: for kickstart allow also timezones not offered by GUI #5345

merged 1 commit into from
Dec 13, 2023

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Nov 27, 2023 •
edited
Loading

Port of #1149 from RHEL 7.

TODO:

  • kickstart test

@pep8speaks
Copy link

pep8speaks commented Nov 27, 2023 •
edited
Loading

Hello @rvykydal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 51:1: E402 module level import not at top of file

Comment last updated at 2023-12-13 09:02:14 UTC

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype time

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@rvykydal
Copy link
Contributor Author

kickstart test: rhinstaller/kickstart-tests#1032

M4rtinK
M4rtinK approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@rvykydal rvykydal added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Dec 12, 2023
@rvykydal @jkonecny12
timezone: for kickstart allow also timezones not offered by GUI
95b2258 
For example Japan, which is linked to Asia/Tokyo in Olson tz database,
and we offer only Asia/Tokyo in GUI.

Resolves: RHEL-13151
Resolves: RHEL-4795
@jkonecny12
Copy link
Member

Hi @rvykydal, just a heads-up I changed commit message to put one more bug to the list which should be solved by this too.

@jkonecny12
Copy link
Member

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member

/kickstart-test --testtype time

@jkonecny12 jkonecny12 merged commit 247edbc into rhinstaller:rhel-8 Dec 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

@M4rtinK M4rtinK M4rtinK approved these changes

Assignees
No one assigned
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel8-branch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rvykydal @pep8speaks @jkonecny12 @M4rtinK @VladimirSlavik