Revert "Remove instperf" #5356
Merged
Revert "Remove instperf" #5356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 359c9e7.
M4rtinK
approved these changes
Nov 30, 2023
poncovka
reviewed
Dec 1, 2023
| from subprocess import Popen, PIPE | ||
| import time | ||
|
|
||
| # grab the top five memory consuming processes, returning them in a string of |
There was a problem hiding this comment.
Could you please extend the comment with information that we have about this script and its use cases?
| mem_logger = logging.getLogger("memLog") | ||
| mem_logger.setLevel(logging.DEBUG) | ||
|
|
||
| handler = logging.FileHandler("/tmp/memory.dat") |
There was a problem hiding this comment.
Could you write a simple kickstart test for this script, please? I think it might be enough to start an installation with the debug kernel option, check if the instperf service is running and make sure that /tmp/memory.dat is not empty.
There was a problem hiding this comment.
please use mkstmp because using /tmp ended up causing problems #5375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 359c9e7.
See #5299 (comment)