Add a simple NVMe module for NVMe Fabrics support #5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vojtechtrefny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-12 13:14:51 UTC |
vojtechtrefny
force-pushed
the
rhel-9_nvme-of-support
branch
from
b8e3c03
to
3a812a3
Compare
This is a bug in blivet on RHEL, we need to fix this before this can be merged, moving the PR to draft for now. |
M4rtinK
reviewed
Dec 11, 2023
tbzatek
suggested changes
Dec 11, 2023
|
Okay, with a simple fix of the above and updated blivet, everything works as expected. Tested via |
|
Please add the Jira issue to the commit messages: https://github.com/rhinstaller/anaconda/blob/rhel-9/CONTRIBUTING.rst#commits-for-rhel-branches |
vojtechtrefny
force-pushed
the
rhel-9_nvme-of-support
branch
from
3a812a3
to
39a944a
Compare
For now we want to support only NVMe Fabrics devices that don't require manual configuration so we need to just make sure the config files in /etc/nvme are fully populated before the installer starts and after the installation copied to the installed system. This is covered by calling the 'startup' and 'write' functions of the Blivet's NVMe module. Resolves: jira#RHEL-10216 Resolves: jira#RHEL-9310 Resolves: jira#RHEL-11543 Resolves: jira#RHEL-11544
Related: jira#RHEL-10216 Related: jira#RHEL-9310 Related: jira#RHEL-11543 Related: jira#RHEL-11544
vojtechtrefny
force-pushed
the
rhel-9_nvme-of-support
branch
from
39a944a
to
8367d32
Compare
tbzatek
approved these changes
Dec 12, 2023
|
Marking as ready for review, the fixed version of blivet is now available in RHEL 9. |
|
/kickstart-test --testtype smoke |
M4rtinK
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #5328 to RHEL 9. We don't need any additional changes for RHEL, the NVMe module was added to blivet in 3.4.0 (3.6.0 is now required on RHEL 9, we have some additional fixes for the module not yet build for RHEL, but the public
startupandwritemethods are available since 9.1) and the libblockdev NVMe plugin dependency is covered by depending on thelibblockdev-plugins-allmeta package.