Rv steffen maier adv stor fixes #5369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvykydal
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
|
/packit propose-downstream |
rvykydal
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
rvykydal
force-pushed
the
rv-steffen-maier-adv-stor-fixes
branch
from
c68f828
to
d9927c7
Compare
rvykydal
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
rvykydal
force-pushed
the
rv-steffen-maier-adv-stor-fixes
branch
from
d9927c7
to
e53e979
Compare
rvykydal
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
rvykydal
force-pushed
the
rv-steffen-maier-adv-stor-fixes
branch
from
e53e979
to
a5f4fec
Compare
rvykydal
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
…(#2046654) Multipath devices themselves do not have a path-id but only their path members. In that case, a good volume identifier is the WWID/WWN/UUID. Fixes: 8e75893 ("Remove the local storage object from the advanced storage spoke") Signed-off-by: Steffen Maier <[email protected]>
Currently, the UI prints the kernel device names for multipath path members. Kernel device names are unpredictable and non-persistent and thus hardly suitable as path identifier for users. This is a preparation providing backend data to be used in a future commit to show in the UI. FCoE, iSCSI, and NVDIMM already have the attribute since commit e74030e ("Add the path-id attribute to the DBus structure for device data"). Provide the same for zfcp-attached SCSI disks, which should always be used with multipathing. This change tolerates the absence of the id_path attribute if the corresponding change adding the attribute in blivet does not exist. Signed-off-by: Steffen Maier <[email protected]>
As user I expect that I can re-run the installation unattendedly when using the generated kickstart file of an interactive installation run (using the same installer boot options plus inst.ks=). Meanwhile, only those zfcp statements from a kickstart file provided as input for an installation run were also written into the generated kickstart file. Fix the missing zfcp statements in the generated kickstart file that originate in user interactions on the storage screen UI. Fixes: d819bb9 ("Remove unused writeKS methods.") Fixes: 0d76185 ("Remove all the writeKS methods except in network and storage.") Signed-off-by: Steffen Maier <[email protected]>
rvykydal
force-pushed
the
rv-steffen-maier-adv-stor-fixes
branch
from
a5f4fec
to
76dec9a
Compare
rvykydal
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should replace #5249, it is the same PR just with required blivet version added.