Fix automatic release on Fedora by importing python-jira in makebumpver late #5400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current approach we are adding unnecessary package requirement for Fedora releases where JIRA is not used at all. Let's move python-jira usage to place where it's used to avoid complexity for Fedora release process and automation.
jkonecny12
added
master
github-actions
bot
added
f40
and removed
infrastructure
|
Infrastructure check failed on these files. Please do a double check of these files before merge! scripts/makebumpver |
|
/kickstart-test --waive infra only |
KKoukiou
reviewed
Jan 12, 2024
| @@ -328,6 +328,9 @@ class MakeBumpVer: | |||
| continue | |||
|
|
|||
| if self.rhel: | |||
| # First place where we need to use JIRA server, don't require it until now | |||
| self._jira.connect() | |||
There was a problem hiding this comment.
Isn't it s/self._jira/self.jira?
There was a problem hiding this comment.
Probably should be but let's not complicate things here. :)
KKoukiou
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current approach we are adding unnecessary package requirement for Fedora releases where JIRA is not used at all. Let's move python-jira usage to place where it's used to avoid complexity for Fedora release process and automation.