Improve multipath identifiers #5412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvykydal
force-pushed
the
improve-multipath-identifiers
branch
from
d3d8470
to
fa7cdda
Compare
…(#2046654) Multipath devices themselves do not have a path-id but only their path members. In that case, a good volume identifier is the WWID/WWN/UUID. Fixes: 8e75893 ("Remove the local storage object from the advanced storage spoke") Signed-off-by: Steffen Maier <[email protected]> Resolves: RHEL-11384
Currently, the UI prints the kernel device names for multipath path members. Kernel device names are unpredictable and non-persistent and thus hardly suitable as path identifier for users. This is a preparation providing backend data to be used in a future commit to show in the UI. FCoE, iSCSI, and NVDIMM already have the attribute since commit e74030e ("Add the path-id attribute to the DBus structure for device data"). Provide the same for zfcp-attached SCSI disks, which should always be used with multipathing. This change tolerates the absence of the id_path attribute if the corresponding change adding the attribute in blivet does not exist. Signed-off-by: Steffen Maier <[email protected]> Related: RHEL-11384
As user I expect that I can re-run the installation unattendedly when using the generated kickstart file of an interactive installation run (using the same installer boot options plus inst.ks=). Meanwhile, only those zfcp statements from a kickstart file provided as input for an installation run were also written into the generated kickstart file. Fix the missing zfcp statements in the generated kickstart file that originate in user interactions on the storage screen UI. Fixes: d819bb9 ("Remove unused writeKS methods.") Fixes: 0d76185 ("Remove all the writeKS methods except in network and storage.") Signed-off-by: Steffen Maier <[email protected]> Related: RHEL-11384
rvykydal
force-pushed
the
improve-multipath-identifiers
branch
from
fa7cdda
to
6f7f41b
Compare
|
Validation tests are failing because of dependencies: waiting for this anaconda update: #5399 - I wouldn't block on that waiting for python-blivet 3.6.0-13 appearing in nightly composes (should happen tonight). |
|
So now only the tests depending on #5399 are failing, as expected. |
|
/kickstart-test --testtype smoke |
poncovka
approved these changes
Jan 22, 2024
Comment on lines
+93
to
+94
| if "wwpn" in dir(fcpdev): | ||
| zd.wwpn = fcpdev.wwpn |
There was a problem hiding this comment.
This code is ported from upstream, isn't it? It should be ideally zd.wwpn = getattr(fcpdev, "wwpn", "") and same for fcplun, but it doesn't make sense to change the original commits here.
jkonecny12
approved these changes
Jan 22, 2024
rvykydal
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.