Do not write LVM devices file during image installation #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
Follow up for rhinstaller#5325 which disables the LVM devices file usage on blivet side but we also need to skip writing the file when writing the storage configuration post install. Resolves: rhbz#2247872
vojtechtrefny
force-pushed
the
master_lvm-devices-image-install-skip
branch
from
c0ed353
to
68456c7
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
KKoukiou
reviewed
Feb 22, 2024
tests/unit_tests/pyanaconda_tests/modules/storage/test_module_storage.py
Show resolved
Hide resolved
KKoukiou
approved these changes
Feb 27, 2024
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #5325 which disables the LVM devices file usage on blivet side but we also need to skip writing the file when writing the storage configuration post install.
Resolves: rhbz#2247872