Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport NVMe-oF to RHEL-10 #5611

Merged
merged 5 commits into from
May 20, 2024
Merged

Backport NVMe-oF to RHEL-10 #5611

merged 5 commits into from
May 20, 2024

Conversation

jkonecny12
Copy link
Member

@jkonecny12 jkonecny12 commented Apr 24, 2024 •
edited
Loading

Backport of #4514 .

Resolves: RHEL-27200

M4rtinK
M4rtinK approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. :)

@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member Author

/build-image --boot.iso

@github-actions GitHub Actions
Copy link

Images built based on commit e0206c4:

  • boot.iso: success

Download the images from the bottom of the job status page.

@jkonecny12
Copy link
Member Author

@jstodola could you please help me with the testing here ^

jstodola
jstodola approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a basic testing passed - the installer shows a tab for NVMe/oF devices.
I wasn't able to do an installation to NVMe/oF device, since the initrd doesn't include the nvmf module yet to activate NVMe/TCP devices automatically.

@jkonecny12
Copy link
Member Author

Thank you for testing!

@jkonecny12 jkonecny12 added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Apr 26, 2024
@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

VladimirSlavik and others added 5 commits May 7, 2024 11:20
@VladimirSlavik @jkonecny12
Install nvme-cli on boot.iso
439ae89 
Install external tooling for managing NVMe-FC devices in the installation
environment. The utilities are needed to manipulate NVM-Express devices,
in this case mainly because of NVMe over Fabrics.

Resolves: RHEL-27200

(cherry picked from commit 369d83a)
(cherry picked from commit a9e2928)
@VladimirSlavik @jkonecny12
Filter out NVMe over Fibre Channel from local disks
15795cd 
Resolves: RHEL-27200

(cherry picked from commit 4b16bc5)
(cherry picked from commit 4e78f3e)
@poncovka @jkonecny12
Update the .glade file for the Advanced Storage screen
904f308 
Apply changes generated by Glade 3.40.0.

Related: RHEL-27200

(cherry picked from commit f63b0ed)
(cherry picked from commit 4da1322)
@VladimirSlavik @jkonecny12
Add a NVMe-FC tab to the Advanced Storage screen
4f02a0d 
Resolves: RHEL-27200

(cherry picked from commit bd0c061)
(cherry picked from commit d40cb44)
@VladimirSlavik @jkonecny12
Add release note for NVMe-oF
8fa3d5d 
Related: RHEL-27200

(cherry picked from commit c9686d6)
@jkonecny12
Copy link
Member Author

Update linked issue in the commit messages and rebased. No changes to the code.

@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

@KKoukiou KKoukiou merged commit d0a99fd into rhinstaller:rhel-10 May 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKoukiou KKoukiou KKoukiou approved these changes

@vojtechtrefny vojtechtrefny vojtechtrefny approved these changes

@jstodola jstodola jstodola approved these changes

@M4rtinK M4rtinK M4rtinK approved these changes

Assignees
No one assigned
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jkonecny12 @M4rtinK @jstodola @vojtechtrefny @KKoukiou @VladimirSlavik @poncovka