[WIP] Add support for /home reuse to automatic partitioning #5799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @rvykydal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-08-06 07:59:35 UTC |
We use destroy only for plain partition mountpoints as we can't destroy lv or btrfs subvolume - it would not free space for the new one (and its vg or btrfs volume). For lvs and btrfs subvols we reuse reformat from mount point assignment (real erase would be perhaps better, even for mount point assignment as recreating the device complicates the logic) TODO: + unify biosboot partition with other stuff (configurable) + look at all roots + test with plain + test with lvm + test with thin lvm + --remove should fail silently? + kickstart support (--erase --reuse --remove) - kickstart tests - reuse fstab mount options (/home is missing compression) + add checks that the device found is unique (including biosboot/efi) - checks for recreate only on plain partition? - create check for usability of the /home reuse (for UI) - update unit tests - luks ? - efi partitions, we have only biosboot so far - update for device_id: rhinstaller#5435 - add better mount point assignment kickstart tests, we update code there (fedora, lvm, plain)
rvykydal
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft, POC of an approach, WIP (see the commit message). Esp. will need to be updated on top of #5435 but that should be fine.
Tested to be working on all partitioning schemes, reuse of unencrypted autopart.
The idea is kickstart (the request structure) just providing flexible enough mechanism, most of the logic, checks, assumptions should be in the UI / client providing the feature.
The kickstart API desn't have to be public/published, now it is just base for the discussion, tests, PartitioningRequest structure update and work on webui UI support.
Related pykickstart PR: pykickstart/pykickstart#499